Add missing filters to bash completion for docker images and docker ps#11904
Merged
jessfraz merged 1 commit intomoby:masterfrom Mar 30, 2015
Merged
Add missing filters to bash completion for docker images and docker ps#11904jessfraz merged 1 commit intomoby:masterfrom
jessfraz merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Harald Albers <[email protected]>
Contributor
There was a problem hiding this comment.
I think these 3 lines are not need, you didn't add this in _docker_ps, why here?
Member
Author
There was a problem hiding this comment.
You're right, there is an asymmetry in this regard between the completions for docker ps and docker images. It is intended, however.
The point is that docker images takes an optional image specification argument. Without the *label=* expression, -f label= would match *) and thus complete images instead of "anything".
As docker ps has no such argument, there's no need to deal with a catch-all glob.
Member
|
@coolljt0725 has a good question, but this LGTM otherwise 👍 |
Member
|
cc @jfrazelle for the merge 😉 |
Contributor
|
LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Mar 30, 2015
Add missing filters to bash completion for docker images and docker ps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @jfrazelle @tianon
cc @coolljt0725