change tag -> repository name (and optionally a tag) in build usage#1182
Merged
change tag -> repository name (and optionally a tag) in build usage#1182
Conversation
Contributor
|
LGTM |
Contributor
Author
|
ping @shykes |
Contributor
|
I don't think that accurate - you can also give it a tag with "-t myapp:v2" |
Contributor
|
(sorry, I posted "lgtm" here by mistake) |
Contributor
Author
|
@shykes do you have anything in mind? I think tag isn't right either. |
Contributor
Author
|
@shykes ping, |
Contributor
Author
|
@shin- @keeb @creack @crosbymichael @unclejack any suggestion ? |
Contributor
|
Perhaps it could be changed to something like: "repository name (and optionally a tag)" to make it clear that the resulting image could also be given a tag, not only a repository name. |
Contributor
Author
|
@unclejack done, |
Contributor
|
It's also not clear from the docs how you give it a name and tag or vice versa. |
Contributor
|
@vieux can you also update the doc? otherwise, LGTM |
vieux
pushed a commit
that referenced
this pull request
Aug 5, 2013
change tag -> repository name (and optionally a tag) in build usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.