Protect jsonfilelog writes with mutex#11472
Merged
estesp merged 1 commit intomoby:masterfrom Mar 18, 2015
LK4D4:logger_mutex
Merged
Protect jsonfilelog writes with mutex#11472estesp merged 1 commit intomoby:masterfrom LK4D4:logger_mutex
estesp merged 1 commit intomoby:masterfrom
LK4D4:logger_mutex
Conversation
Contributor
There was a problem hiding this comment.
unlock here or add defer l.mu.Unlock()?
Signed-off-by: Alexander Morozov <[email protected]>
Contributor
Author
|
@estesp Fixed |
Contributor
|
wooohoooo |
Contributor
|
jenkins failed bc of TestPullVerified so unrelated, LGTM |
Contributor
|
LGTM |
estesp
added a commit
that referenced
this pull request
Mar 18, 2015
Protect jsonfilelog writes with mutex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes panic on jenkins.
ping @estesp