New libcontainer api#11208
Merged
Merged
Conversation
Signed-off-by: Alexander Morozov <[email protected]>
Signed-off-by: Alexander Morozov <[email protected]>
Contributor
|
Whoa nice, so @icecrime does this mean we can make the hairpin nat PR after? |
Contributor
Author
|
@jfrazelle Yup, indeed. And probably we can remove userland-proxy :) |
Contributor
|
LGTM |
Contributor
Author
|
ping @tiborvass @jfrazelle @icecrime |
Contributor
|
I made a few minor comments; but I've reviewed the Docker integration code (not the libcontainer vendor update) and LGTM |
Contributor
|
LGTM |
Contributor
Contributor
Author
|
@jfrazelle haha, that's expected :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not fully finished integration(there are a lot ugly places, which can be much nicer), but this code contains new libcontainer API, so we can test it and find some bugs.
ping @crosbymichael