Docker Tag command: Relax the restriction on namespace (username) length from 30 to 255 characters. by shishir-a412ed · Pull Request #11118 · moby/moby

shishir-a412ed · 2015-03-02T21:14:08Z

This change relaxes the restriction on namespace (username) from 30 to 255 characters.

Issue related to this: #10392

Shishir

ncdc · 2015-03-02T22:06:37Z

registry/config.go

You'll want to update the error text

Thanks @ncdc for the catch !
I have updated the code.

thaJeztah · 2015-03-03T07:37:31Z

Note to reviewers; it looks like the limit in registry v2 has not yet been updated, see #10392 (comment)

ncdc · 2015-03-05T15:05:13Z

registry/config.go

The v2 registry currently has a minimum of 2, not 4: https://github.com/docker/distribution/blob/master/registry/api/v2/names.go#L16

ncdc · 2015-03-05T15:05:42Z

The current max in the v2 registry is 255, not 256: https://github.com/docker/distribution/blob/master/registry/api/v2/names.go#L32

ncdc · 2015-03-06T14:29:18Z

This PR for the v2 registry removes the 30-character component limit distribution/distribution#242

crosbymichael · 2015-03-06T18:35:42Z

@dmp42 @dmcgowan

Please review

dmp42 · 2015-03-06T21:25:15Z

@shishir-a412ed can you update the comparison to 255?
Thanks.

dmcgowan · 2015-03-07T01:52:18Z

Ping @ncdc can you drive forward getting this updated to match the rules in distribution

ncdc · 2015-03-07T01:57:51Z

Yes, I chatted with Shishir today about updating it to match. I'll follow
up on Monday. Thanks.
On Fri, Mar 6, 2015 at 8:53 PM Derek McGowan [email protected]
wrote:

Ping @ncdc https://github.com/ncdc can you drive forward getting this
updated to match the rules in distribution

—
Reply to this email directly or view it on GitHub
#11118 (comment).

stevvooe · 2015-03-09T18:36:30Z

Updated ticket title to reflect the correct limit.

stevvooe · 2015-03-13T21:10:52Z

registry/registry_test.go

Could replace this with a testcase that triggers the short case?

stevvooe · 2015-03-13T21:11:09Z

LGTM with testcase for short namespace.

dmcgowan · 2015-03-13T21:14:13Z

Commit message hasn't been changed to reflect 255 instead of 256 characters

shishir-a412ed · 2015-03-13T22:18:12Z

@dmcgowan Updated the commit message to reflect 255.

shishir-a412ed · 2015-03-14T16:10:17Z

@stevvooe I have added 2 testcases, one for short, and one for long namespaces.

…gth from 30 to 255 characters. Signed-off-by: Shishir Mahajan <[email protected]>

dmcgowan · 2015-03-16T17:04:41Z

LGTM

stevvooe · 2015-03-16T19:01:13Z

LGTM

ncdc · 2015-03-17T13:50:42Z

@icecrime what are the next steps here?

vbatts · 2015-03-17T14:19:49Z

i've just issued a rebuild to windows, but the linux tests are looking fine.

icecrime · 2015-03-17T16:38:26Z

Windows CI is green after rebuild: pushing to 3-docs-review.

ncdc · 2015-03-17T16:40:04Z

@icecrime thanks. FYI I grepped through the Docker codebase and the only references I could find (quickly) to a 30 character maximum were the docker io API and the hub registry spec docs, both of which talk about hub/registry usernames needing to be no more than 30.

icecrime · 2015-03-17T16:40:58Z

Good, I was running the same search on my side and can't see any reference to these limits in docs/ either :-) Thanks!

…ngth Docker Tag command: Relax the restriction on namespace (username) length from 30 to 255 characters.

GordonTheTurtle added the status/0-triage label Mar 2, 2015

shishir-a412ed mentioned this pull request Mar 2, 2015

Allowing nested username (e.g. /rhat/smahajan/) in docker tag command #11115

Closed

ncdc reviewed Mar 2, 2015
View reviewed changes

shishir-a412ed force-pushed the restriction_username_length branch from f3870dd to a8cc254 Compare March 2, 2015 22:09

jessfraz added status/2-code-review and removed status/0-triage labels Mar 4, 2015

ncdc reviewed Mar 5, 2015
View reviewed changes

dmp42 added the Distribution label Mar 6, 2015

dmcgowan added this to the 1.6.0 milestone Mar 7, 2015

dmp42 assigned stevvooe Mar 7, 2015

shishir-a412ed force-pushed the restriction_username_length branch 3 times, most recently from 63b51a0 to cca2eee Compare March 9, 2015 15:01

stevvooe changed the title ~~Docker Tag command: Relax the restriction on namespace (username) length from 30 to 256 characters.~~ Docker Tag command: Relax the restriction on namespace (username) length from 30 to 255 characters. Mar 9, 2015

stevvooe reviewed Mar 13, 2015
View reviewed changes

registry/registry_test.go

Copy link

Contributor

stevvooe Mar 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could replace this with a testcase that triggers the short case?

shishir-a412ed force-pushed the restriction_username_length branch 2 times, most recently from 85ce071 to 593619d Compare March 13, 2015 22:17

shishir-a412ed force-pushed the restriction_username_length branch 2 times, most recently from 703d32b to ab3f8eb Compare March 14, 2015 15:30

Docker Tag command: Relax the restriction on namespace (username) len…

9839e97

…gth from 30 to 255 characters. Signed-off-by: Shishir Mahajan <[email protected]>

shishir-a412ed force-pushed the restriction_username_length branch from ab3f8eb to 9839e97 Compare March 14, 2015 20:46

icecrime added status/3-docs-review and removed status/2-code-review labels Mar 17, 2015

icecrime added status/4-merge and removed status/3-docs-review labels Mar 17, 2015

icecrime pushed a commit that referenced this pull request Mar 17, 2015

Merge pull request #11118 from shishir-a412ed/restriction_username_le…

a751cc5

…ngth Docker Tag command: Relax the restriction on namespace (username) length from 30 to 255 characters.

icecrime merged commit a751cc5 into moby:master Mar 17, 2015

vieux removed the status/4-merge label Mar 17, 2015

ncdc mentioned this pull request Mar 17, 2015

Please increase the 30-character image repository name limitation #10392

Closed

mkjois mentioned this pull request Sep 26, 2017

Tag repository limited to 30 characters bmuschko/gradle-docker-plugin#469

Closed

fabiokung mentioned this pull request Jun 26, 2019

Docker image metadata in the container ENV Netflix/titus-executor#268

Merged

thaJeztah mentioned this pull request Aug 14, 2024

Exclude domain from name length check distribution/reference#9

Merged

adskyiproger mentioned this pull request Nov 13, 2025

feat: Add husky branch validation opencrvs/infrastructure#187

Merged

This was referenced Nov 21, 2025

feat: Add branch name validation opencrvs/opencrvs-core#11150

Merged

Add husky pre-push hooks opencrvs/opencrvs-countryconfig#1159

Merged

cibelius mentioned this pull request Nov 24, 2025

fix husky yarn change opencrvs/opencrvs-countryconfig#1161

Merged

5 tasks

Conversation

shishir-a412ed commented Mar 2, 2015

Uh oh!

ncdc Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

shishir-a412ed Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Mar 3, 2015

Uh oh!

ncdc Mar 5, 2015

Choose a reason for hiding this comment

Uh oh!

ncdc commented Mar 5, 2015

Uh oh!

ncdc commented Mar 6, 2015

Uh oh!

crosbymichael commented Mar 6, 2015

Uh oh!

dmp42 commented Mar 6, 2015

Uh oh!

dmcgowan commented Mar 7, 2015

Uh oh!

ncdc commented Mar 7, 2015

Uh oh!

stevvooe commented Mar 9, 2015

Uh oh!

stevvooe Mar 13, 2015

Choose a reason for hiding this comment

Uh oh!

stevvooe commented Mar 13, 2015

Uh oh!

dmcgowan commented Mar 13, 2015

Uh oh!

shishir-a412ed commented Mar 13, 2015

Uh oh!

shishir-a412ed commented Mar 14, 2015

Uh oh!

dmcgowan commented Mar 16, 2015

Uh oh!

stevvooe commented Mar 16, 2015

Uh oh!

ncdc commented Mar 17, 2015

Uh oh!

vbatts commented Mar 17, 2015

Uh oh!

icecrime commented Mar 17, 2015

Uh oh!

ncdc commented Mar 17, 2015

Uh oh!

icecrime commented Mar 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants