Skip to content

fixed #910. print user name to docker info output#1093

Merged
creack merged 3 commits intomoby:masterfrom
monnand:910-login-info
Aug 7, 2013
Merged

fixed #910. print user name to docker info output#1093
creack merged 3 commits intomoby:masterfrom
monnand:910-login-info

Conversation

@monnand
Copy link
Contributor

@monnand monnand commented Jul 1, 2013

fixed #910.
Example output:

$ ./docker info
Containers: 12
Images: 3
Username: monnand
Registry: https://index.docker.io/v1
WARNING: No swap limit support

@vieux
Copy link
Contributor

vieux commented Jul 1, 2013

I think the registry url should be sent by the server to the client.
Only the username is "client-side"

@monnand
Copy link
Contributor Author

monnand commented Jul 1, 2013

@vieux Well.. The registry field is required in #910. It won't hurt to remove (or add) it.

@vieux
Copy link
Contributor

vieux commented Jul 1, 2013

Yes, I was just saying you should get it from APIInfo

@vieux
Copy link
Contributor

vieux commented Jul 10, 2013

@monnand do you see what I mean ?, the registry is used server-side, therefore it should be sent by the server (via APIInfo)

@monnand
Copy link
Contributor Author

monnand commented Jul 10, 2013

@vieux Oops. It seems like I missed the email. Sorry about that. Do you mean I need to add another field in APIInfo containing registry URL?

@vieux
Copy link
Contributor

vieux commented Jul 10, 2013

@monnand yes exactly, and don't use auth.IndexServerAddress() client side

@monnand
Copy link
Contributor Author

monnand commented Jul 10, 2013

@vieux OK. I will do it this weekend. (Kind of busy after the holiday.)

@shykes
Copy link
Contributor

shykes commented Jul 18, 2013

I'm closing this to help bookkeeping, feel free to re-open when you want us to consider it again!

@shykes shykes closed this Jul 18, 2013
@monnand
Copy link
Contributor Author

monnand commented Jul 22, 2013

@shykes Sorry for the delay. I just committed a new patch. Do I need to open a new pull request or re-open this existing one? (I didn't find how to re-open this pull request. I think I do not have permission to do that.)

@kencochrane kencochrane reopened this Jul 22, 2013
@kencochrane
Copy link
Contributor

kencochrane commented Jul 22, 2013

@monnand I just reopened it, feel free to use this one again.

@monnand
Copy link
Contributor Author

monnand commented Jul 22, 2013

I just rebased to the master branch. Please take another look.

@kencochrane
Copy link
Contributor

kencochrane commented Jul 22, 2013

ping @vieux

@crosbymichael
Copy link
Contributor

crosbymichael commented Aug 5, 2013

@monnand Could you please rebase once again?

@monnand
Copy link
Contributor Author

monnand commented Aug 5, 2013

@crosbymichael Sure. I'll do it later

@monnand
Copy link
Contributor Author

monnand commented Aug 6, 2013

Please take another look.

@vieux
Copy link
Contributor

vieux commented Aug 6, 2013

LGTM

1 similar comment
@creack
Copy link
Contributor

creack commented Aug 7, 2013

LGTM

creack added a commit that referenced this pull request Aug 7, 2013
@creack
Merge pull request #1093 from monnand/910-login-info
65a4e30 
* Runtime: fixed #910. print user name to docker info output
@creack creack merged commit 65a4e30 into moby:master Aug 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add currently logged in user to docker info output

6 participants

@monnand @vieux @shykes @kencochrane @crosbymichael @creack