Skip to content

daemon/graphdriver/aufs: enable direct io#10534

Merged
tiborvass merged 1 commit intomoby:masterfrom
unclejack:aufs_enable_dio
Feb 6, 2015
Merged

daemon/graphdriver/aufs: enable direct io#10534
tiborvass merged 1 commit intomoby:masterfrom
unclejack:aufs_enable_dio

Conversation

@unclejack
Copy link
Contributor

This PR fixes #8119 for AUFS by enabling direct IO in the mount options. Direct IO is only used when requested. Should direct io not be supported by the underlying file system, the same error as now is passed on to the application.

Fixes #8119

@crosbymichael
Copy link
Contributor

Should this be one of the --storage-opts aufs:directio or is this a safe default?

@unclejack
Copy link
Contributor Author

@crosbymichael It's a safe default because:

  • currently, requests for direct io from application code are failing
  • should the underlying fs not support direct io, the requests would fail as they are failing now
  • dio is supported on all kernels with aufs where Docker runs (3.10+)

@crosbymichael
Copy link
Contributor

LGTM

@tiborvass tiborvass added this to the 1.5.1 milestone Feb 6, 2015
@tiborvass
Copy link
Contributor

Reminds me of #10390. I should probably do the same as here.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MySQL dump import takes a long long time (innoDB)

5 participants