Env Variables created for each of the ports in addition to env variables...#10061
Env Variables created for each of the ports in addition to env variables...#10061crosbymichael merged 1 commit intomoby:masterfrom
Conversation
|
Can you please sign your commits following these rules: The easiest way to do this is to amend the last commit:
|
There was a problem hiding this comment.
Why not just for _, p := range l.Ports?
There was a problem hiding this comment.
Yes no reason now, just a copy of old code. I changes it now.
30b67e0 to
7bca6bb
Compare
|
LGTM |
|
We should probably add a few integration tests to enforce the environment variables for a container or it maybe pretty easy to write a unit test for this method. |
|
Yup, +1 to tests. |
|
@crosbymichael @LK4D4 Thanks for the review. I will add tests shortly. One scenario that I am not very convinced about is that env for range may show differently, for example |
…les for port ranges, regression from moby#1834 Closes moby#9900 Signed-off-by: Srini Brahmaroutu <[email protected]>
7bca6bb to
611a23a
Compare
|
Please see that I added a unit test for check all env variables. |
|
LGTM |
|
@LK4D4 Anything else to add to this or can we merge? |
|
Thanks for the tests! |
Env Variables created for each of the ports in addition to env variables...
... for port ranges, regression from #1834
Closes #9900
Signed-off-by: Srini Brahmaroutu [email protected]