Add --link accept container ID#10056
Merged
crosbymichael merged 2 commits intomoby:masterfrom Jan 14, 2015
Merged
Conversation
Signed-off-by: Lei Jitang <[email protected]>
Contributor
Author
|
Fix #5186 |
Member
|
I love how small the diff here is. 👍 I'll bet @LK4D4 is going to come asking for a test or two soon though. 😄 |
Contributor
Author
|
@tianon 😄 haha,maybe I should add tests before his asking. |
Contributor
|
LGTM Please add a test though |
coolljt0725
force-pushed
the
add_link_accept_ID
branch
from
fe4d00b to
2c03850
Compare
Signed-off-by: Lei Jitang <[email protected]>
coolljt0725
force-pushed
the
add_link_accept_ID
branch
from
2c03850 to
2292167
Compare
Contributor
Author
|
Update,Add tests |
Contributor
|
nice LGTM |
crosbymichael
added a commit
that referenced
this pull request
Jan 14, 2015
Add --link accept container ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --link only accept container names right now,but we can't find a
reason to prevent us from using a container id to link target.We don't always to assign
a name to a container and use its id to identify it.Some other option such as
--volumes-fromcan accept both container names and id,so it's weird
--linkonly accept container name. Thispatch add
--linkaccept container ID.Signed-off-by: Lei Jitang [email protected]
Fixes #5186