A potential goroutine leak in daemon/logger/ring_test.go #49717
Description
Description
When the newRingLogger is created.
moby/daemon/logger/ring_test.go
Lines 25 to 28 in 37f8662
The
defer ring.Close() method should be called to awaken the cond.Wait().Lines 192 to 194 in 37f8662
However, the actual method invoked is
defer ring.setClosed(), which doesn't invoke r.wait.Broadcast(), resulting in goroutine leak.
Reproduce
You could use goleak to reproduce the bug in the function as follows.
moby/daemon/logger/ring_test.go
Line 25 in 37f8662
func TestRingLogger(t *testing.T) {
defer goleak.VerifyNone(t)
xxx
}
The result is similar to this：
Expected behavior
How to fix the bug:
invoking defer ring.Close() instead of defer ring.setClosed() in the function.
docker version
latestdocker info
-Additional Info
No response