Description
Related to
We currently disable various "Attach" tests on Windows; possibly due to ANSI control characters appearing in the output.
We should consider testing both with and without a TTY attached. wsContainersAttach calls out to ContainerAttach
|
err = s.backend.ContainerAttach(containerName, attachConfig) |
which contains logic based on wether the container has a TTY or not;
|
multiplexed := !ctr.Config.Tty && c.MuxStreams |
|
inStream, outStream, errStream, err := c.GetStreams(multiplexed) |
🤔 So, I guess that's covered in TestPostContainersAttach, which also is disabled on Windows (perhaps for the exact reason mentioned above?);
|
func (s *DockerAPISuite) TestPostContainersAttach(c *testing.T) { |
|
testRequires(c, DaemonIsLinux) |
When fixing that, we should also consider rewriting that test to use subtests, as it looks like it's testing quite some variations.
Description
Related to
We currently disable various "Attach" tests on Windows; possibly due to ANSI control characters appearing in the output.
We should consider testing both with and without a TTY attached.
wsContainersAttachcalls out toContainerAttachmoby/api/server/router/container/container_routes.go
Line 756 in cf8b057
which contains logic based on wether the container has a TTY or not;
moby/daemon/attach.go
Lines 53 to 54 in cf8b057
🤔 So, I guess that's covered in
TestPostContainersAttach, which also is disabled on Windows (perhaps for the exact reason mentioned above?);moby/integration-cli/docker_api_attach_test.go
Lines 98 to 99 in a61f7ab
When fixing that, we should also consider rewriting that test to use subtests, as it looks like it's testing quite some variations.