Skip to content

containerd integration: image delete should send image "untag" events and prometheus counters #43855

Closed
#47555
Closed
containerd integration: image delete should send image "untag" events and prometheus counters#43855
#47555
Labels
area/imagesImage Servicearea/metricsarea/metrics/prometheuscontainerd-integrationIssues and PRs related to containerd integrationkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.
@thaJeztah

Description

@thaJeztah
thaJeztah
opened on Jul 21, 2022

Description

The existing implementation sends untag

moby/daemon/images/image_delete.go

Line 106 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

moby/daemon/images/image_delete.go

Line 169 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

moby/daemon/images/image_delete.go

Line 255 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

moby/daemon/images/image_delete.go

Line 106 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

Prometheus counters;

moby/daemon/images/image_delete.go

Line 179 in b94f715

imageActions.WithValues("delete").UpdateSince(start)

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/imagesImage Servicearea/metricsarea/metrics/prometheuscontainerd-integrationIssues and PRs related to containerd integrationkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.

    Type

    No type

    Projects

    containerd integration

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions