Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test TestServiceWithPredefinedNetwork #36547

Closed
thaJeztah opened this issue Mar 9, 2018 · 1 comment · Fixed by #36551
Closed

Flaky test TestServiceWithPredefinedNetwork #36547

thaJeztah opened this issue Mar 9, 2018 · 1 comment · Fixed by #36551
Labels
area/testing kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. status/needs-attention Calls for a collective discussion during a review session

Comments

@thaJeztah
Copy link
Member

This test was added recently in #36316, but is failing on a lot of PR's with:

13:46:02 --- FAIL: TestServiceWithPredefinedNetwork (12.36s)
13:46:02 	daemon.go:283: [d47ab7ceb5568] waiting for daemon to start
13:46:02 	daemon.go:315: [d47ab7ceb5568] daemon started
13:46:02 	service_test.go:52: timeout hit after 10s: task count at 1 waiting for 0
13:46:02 	daemon.go:273: [d47ab7ceb5568] exiting daemon
13:46:02 FAIL

Failure is in the teardown of the test;

moby/integration/network/service_test.go

Line 52 in 0b0af85

poll.WaitOn(t, noTasks(client), pollSettings)

/cc @selansen
@thaJeztah thaJeztah added kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. status/needs-attention Calls for a collective discussion during a review session area/testing labels Mar 9, 2018
This was referenced Mar 9, 2018
Merged
Open
Merged
This was referenced Mar 13, 2018
Merged
Merged
This was referenced Mar 13, 2018
Closed
Merged
This was referenced Mar 16, 2018
Closed
Merged
@kolyshkin
Copy link
Contributor

I just found this PR: #36551, looks like it addresses the issue

@kolyshkin kolyshkin mentioned this issue Mar 16, 2018
Closed
@thaJeztah thaJeztah mentioned this issue Mar 16, 2018
Merged
@selansen selansen mentioned this issue Mar 16, 2018
Merged
@anusha-ragunathan anusha-ragunathan mentioned this issue Mar 20, 2018
Merged
@thaJeztah thaJeztah mentioned this issue Jun 18, 2018
Open
@thaJeztah thaJeztah mentioned this issue Jul 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. status/needs-attention Calls for a collective discussion during a review session
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Flaky test TestServiceWithPredefinedNetwork selansen/moby
2 participants
@thaJeztah @kolyshkin