Status code images load API returns is misleading #34416
Description
Description
Docker images load API return 200 status code when it actually failed. I wonder it's by design or a bug.
Steps to reproduce the issue:
cat /mychai/PACKAGE_ICON.PNG |curl -v --unix-socket /var/run/docker.sock -H "Content-Type: application/x-tar" --data-binary @- -X POST http:/v1.29/images/loadDescribe the results you received:
> POST /images/load HTTP/1.1
> Host: v1.29
> User-Agent: curl/7.54.0
> Accept: */*
> Content-Type: application/x-tar
> Content-Length: 7164
> Expect: 100-continue
>
< HTTP/1.1 100 Continue
< HTTP/1.1 200 OK
< Api-Version: 1.29
< Content-Type: application/json
< Docker-Experimental: false
< Ostype: linux
< Server: Docker/17.05.0-ce (linux)
< Date: Mon, 07 Aug 2017 05:48:35 GMT
< Transfer-Encoding: chunked
<
{"errorDetail":{"message":"Error processing tar file(exit status 1): archive/tar: invalid tar header"},"error":"Error processing tar file(exit status 1): archive/tar: invalid tar header"}
Describe the results you expected:
< HTTP/1.1 500
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
Client:
Version: 17.05.0-ce
API version: 1.29
Go version: go1.8
Git commit: 54e4c6c-synology
Built: Fri Aug 4 22:43:08 2017
OS/Arch: linux/amd64
Server:
Version: 17.05.0-ce
API version: 1.29 (minimum version 1.12)
Go version: go1.8
Git commit: 54e4c6c-synology
Built: Fri Aug 4 22:43:08 2017
OS/Arch: linux/amd64
Experimental: false
Output of docker info:
Containers: 12
Running: 1
Paused: 0
Stopped: 11
Images: 27
Server Version: 17.05.0-ce
Storage Driver: btrfs
Logging Driver: db
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: fd189da3e13a3ef3d6d9eb73c5cd4697b4536cdd (expected: 9048e5e50717ea4497b757314bad98ea3763c145)
runc version: a2d6e07aab95ff37fb63cf5dec3c40d29940194f (expected: 9c2d8d184e5da67c95d601382adf14862e4f2228)
init version: 7a83305 (expected: 949e6fa)
Security Options:
apparmor
Kernel Version: 3.10.105
Operating System: <unknown>
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 988.7MiB
Name: tricia713p-2
ID: N44J:NJHE:EQG2:TY6P:QYPH:DXP5:2X2G:F5C2:2ONN:OGTF:J45U:LCVG
Docker Root Dir: /volume1/@docker
Debug Mode (client): false
Debug Mode (server): true
File Descriptors: 20
Goroutines: 29
System Time: 2017-08-07T13:53:50.426017437+08:00
EventsListeners: 0
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: No kernel memory limit support
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support
Additional environment details (AWS, VirtualBox, physical, etc.):
Linux