Description
Docker build used to work with [email protected]:user/repo.git. This breaks with golang 1.8 because url.Parse no longer accepts urls like this (https://golang.org/doc/go1.8#net_url)
Relevant code at:
|
u, err := url.Parse(remoteURL) |
|
validPrefixes = map[string][]string{ |
Steps to reproduce the issue:
$ docker build [email protected]:docker/docker.git
Describe the results you received:
unable to prepare context: unable to 'git clone' to temporary context directory: parse [email protected]:docker/docker.git: first path segment in URL cannot contain colon
Describe the results you expected:
This used to clone and build the repository.
Additional information you deem important (e.g. issue happens only occasionally):
Requires golang 1.8
Output of docker version:
> $ docker version
Client:
Version: 17.05.0-ce
API version: 1.29
Go version: go1.8.1
Git commit: 89658bed64
Built: Fri May 5 22:40:58 2017
OS/Arch: linux/amd64
Server:
Version: 17.05.0-ce
API version: 1.29 (minimum version 1.12)
Go version: go1.8.1
Git commit: 89658bed64
Built: Fri May 5 22:40:58 2017
OS/Arch: linux/amd64
Experimental: false
Output of docker info:
> $ docker info
Containers: 4
Running: 0
Paused: 0
Stopped: 4
Images: 587
Server Version: 17.05.0-ce
Storage Driver: devicemapper
Pool Name: docker-254:3-2491281-pool
Pool Blocksize: 65.54kB
Base Device Size: 10.74GB
Backing Filesystem: xfs
Data file: /dev/loop0
Metadata file: /dev/loop1
Data Space Used: 7.808GB
Data Space Total: 107.4GB
Data Space Available: 87.62GB
Metadata Space Used: 40.81MB
Metadata Space Total: 2.147GB
Metadata Space Available: 2.107GB
Thin Pool Minimum Free Space: 10.74GB
Udev Sync Supported: true
Deferred Removal Enabled: false
Deferred Deletion Enabled: false
Deferred Deleted Device Count: 0
Data loop file: /var/lib/docker/devicemapper/devicemapper/data
Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
Library Version: 1.02.140 (2017-05-03)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 9048e5e50717ea4497b757314bad98ea3763c145
runc version: 9c2d8d184e5da67c95d601382adf14862e4f2228
init version: 949e6fa
Security Options:
seccomp
Profile: default
Kernel Version: 4.11.3-1-ARCH
Operating System: Arch Linux
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.704GiB
Name: pandacow
ID: YPJM:6M3G:BOXR:FTIE:X74P:E7DY:FKOB:BUKK:SUNI:QWHR:NUG3:B2YC
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: devicemapper: usage of loopback devices is strongly discouraged for production use.
Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
Additional environment details (AWS, VirtualBox, physical, etc.):
Description
Docker build used to work with
[email protected]:user/repo.git. This breaks with golang 1.8 becauseurl.Parseno longer accepts urls like this (https://golang.org/doc/go1.8#net_url)Relevant code at:
moby/builder/remotecontext/git/gitutils.go
Line 29 in b28cbed
moby/pkg/urlutil/urlutil.go
Line 11 in b248de7
Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
This used to clone and build the repository.
Additional information you deem important (e.g. issue happens only occasionally):
Requires golang 1.8
Output of
docker version:Output of
docker info:Additional environment details (AWS, VirtualBox, physical, etc.):