Related to #32872
opts/ is mostly used by docker/cli. There are a few uses of it in moby/moby, but many of those don't overlap with the parts used in docker/cli.
These are only used in moby/moby:
NamedOptionNewNamedListOptsRef (technically imported in docker/cli, but not actually needed)ParseLinkDefault*NewNamedMapOpts
We should be able to split this package, and move the rest to docker/cli. The validation functions may need to be split out and kept in moby/moby for now.
opts in moby/moby:
cli/flags/common.go:opts.NewNamedListOptsRef
cli/flags/common.go:opts.NewQuotedString
cli/flags/common.go:opts.ValidateHost
cmd/dockerd/config_common_unix.go:opts.NewIPOpt
cmd/dockerd/config_common_unix.go:opts.NewNamedRuntimeOpt
cmd/dockerd/config.go:opts.NewListOptsRef
cmd/dockerd/config.go:opts.NewNamedListOptsRef
cmd/dockerd/config.go:opts.NewNamedMapOpts
cmd/dockerd/config.go:opts.ValidateDNSSearch
cmd/dockerd/config.go:opts.ValidateIPAddress
cmd/dockerd/config.go:opts.ValidateLabel
cmd/dockerd/config_unix.go:opts.MemBytes
cmd/dockerd/config_unix.go:opts.NewUlimitOpt
cmd/dockerd/daemon.go:opts.ParseHost
container/container.go:opts.ParseLink
daemon/cluster/swarm.go:opts.ParseTCPAddr
daemon/config/config.go:opts.NamedOption
daemon/config/config.go:opts.ValidateDNSSearch
daemon/config/config.go:opts.ValidateIPAddress
daemon/config/config.go:opts.ValidateLabel
daemon/config/config_test.go:opts.NewNamedListOptsRef
daemon/config/config_test.go:opts.ValidateHost
daemon/config/config_unix.go:opts.MemBytes
daemon/container.go:opts.ValidateEnv
daemon/container.go:opts.ValidateExtraHost
daemon/container_operations.go:opts.ValidateExtraHost
daemon/daemon_unix.go:opts.ParseLink
integration-cli/daemon/daemon.go:opts.DefaultHTTPHost
integration-cli/daemon/daemon.go:opts.DefaultTLSHTTPPort
integration-cli/daemon/daemon.go:opts.DefaultUnixSocket
integration-cli/environment/environment.go:opts.DefaultUnixSocket
integration-cli/request/request.go:opts.DefaultUnixSocket
registry/config.go:opts.NewNamedListOptsRef
cc @vieux @tiborvass @vdemeester
Related to #32872
opts/is mostly used bydocker/cli. There are a few uses of it inmoby/moby, but many of those don't overlap with the parts used indocker/cli.These are only used in moby/moby:
NamedOptionNewNamedListOptsRef(technically imported in docker/cli, but not actually needed)ParseLinkDefault*NewNamedMapOptsWe should be able to split this package, and move the rest to
docker/cli. The validation functions may need to be split out and kept inmoby/mobyfor now.optsin moby/moby:cc @vieux @tiborvass @vdemeester