An issue was opened recently for runc (opencontainers/runc#1364) that has alerted us to the fact that syscall's TCGETS/TCSETS aren't correct for all platforms.
Steps to reproduce the issue:
Currently the only place we've seen this manifest itself is in the logrus test cases, which we just skipped on power since they didn't seem urgent to fix (just colors were broken).
Has there been any prior discussion on moving? It looks like the only place in the code that uses those two ioctls is in pkg/term, so that could be an initial PR.
Also a benefit of moving to sys is that you don't have to wait for new releases of go to get fixes (as with syscall).
Describe the results you received:
.
Describe the results you expected:
.
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
all versions
Output of docker info:
n/a
Additional environment details (AWS, VirtualBox, physical, etc.):
An issue was opened recently for runc (opencontainers/runc#1364) that has alerted us to the fact that syscall's TCGETS/TCSETS aren't correct for all platforms.
Steps to reproduce the issue:
Currently the only place we've seen this manifest itself is in the logrus test cases, which we just skipped on power since they didn't seem urgent to fix (just colors were broken).
Has there been any prior discussion on moving? It looks like the only place in the code that uses those two ioctls is in pkg/term, so that could be an initial PR.
Also a benefit of moving to sys is that you don't have to wait for new releases of go to get fixes (as with syscall).
Describe the results you received:
.
Describe the results you expected:
.
Additional information you deem important (e.g. issue happens only occasionally):
Output of
docker version:all versions
Output of
docker info:n/a
Additional environment details (AWS, VirtualBox, physical, etc.):