Skip to content

Enable engine to mirror private registry #18818

@TrumanLing

Description

@TrumanLing

**Issue Summary:**Now I'm using DTR(docker trusted registry) on trial, and setup mirror for DTR,but engine can't support to mirror private registry.

**Proposal:**Make Implementation to let engine have cap of mirroring private registry
1. extend registry-mirror option as format mirror addr@mian hub addr
_2._refactor func lookupV2Endpoints to manage mirrors' endpoint, main hubs' endpoint and map mirror address and mian hub address, at the same time simplify func ValidateMirror as well.

How about your opinion???

I have implemented it, if you agree with that, I will make a PR.

Environmental info:
#docker version

Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   a34a1d5
 Built:        Fri Nov 20 13:12:04 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   a34a1d5
 Built:        Fri Nov 20 13:12:04 UTC 2015
 OS/Arch:      linux/amd64```

#docker info
Containers: 5
Images: 536
Server Version: 1.9.1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 546
 Dirperm1 Supported: false
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.13.0-55-generic
Operating System: Ubuntu 14.04.2 LTS
CPUs: 4
Total Memory: 3.543 GiB
Name: truman
ID: LRJ5:KBA2:ZWDX:3CVK:2QO2:OARR:UCHX:IFFJ:ZZS4:HZ4M:5KOZ:2OD6
Http Proxy: http://l00316595:4f5g6h%[email protected]:8080
Https Proxy: https://l00316595:4f5g6h%[email protected]:8080
No Proxy: rnd-dockerhub.huawei.com,10.110.52.35,10.110.52.75
WARNING: No swap limit support

#uname -a
Linux truman 3.13.0-55-generic #94-Ubuntu SMP Thu Jun 18 00:27:10 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions