Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/moby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v23.0.0-rc.3
Choose a base ref
...
head repository: moby/moby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v23.0.0
Choose a head ref
  • 12 commits
  • 21 files changed
  • 5 contributors

Commits on Jan 30, 2023

  1. [23.0] update containerd binary to v1.6.16 

    Notable Updates

- Fix push error propagation
- Fix slice append error with HugepageLimits for Linux
- Update default seccomp profile for PKU and CAP_SYS_NICE
- Fix overlayfs error when upperdirlabel option is set

full diff: containerd/containerd@v1.6.15...v1.6.16

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    26e9fac View commit details
    Browse the repository at this point in the history

  2. client: improve error messaging on crash 

    Repro steps:
- Run Docker Desktop
- Run `docker run busybox tail -f /dev/null`
- Run `pkill "Docker Desktop"

Expected:
An error message that indicates that Docker Desktop is shutting down.

Actual:
An error message that looks like this:

```
error waiting for container: invalid character 's' looking for beginning of value
```

here's an example:

docker/for-mac#6575 (comment)

After this change, you get an error message like:

```
error waiting for container: copying response body from Docker: unexpected EOF
```

which is a bit more explicit.

Signed-off-by: Nick Santos <[email protected]>
(cherry picked from commit 9900c7a)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @nicks @thaJeztah
    nicks authored and thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8b83e09 View commit details
    Browse the repository at this point in the history

  3. hack: remove -installsuffix build flag 

    Has been introduced in 232d59b to work around a bug with
"go build" but not required anymore since go 1.5: golang/go@4dab6d0

Signed-off-by: CrazyMax <[email protected]>
(cherry picked from commit 0c008cc)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @crazy-max @thaJeztah
    crazy-max authored and thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    df2fe70 View commit details
    Browse the repository at this point in the history

  4. hack: remove ORIG_BUILDFLAGS var 

    This var was used for the cross target but it has been removed
in 8086f40 so not necessary anymore

Signed-off-by: CrazyMax <[email protected]>
(cherry picked from commit b80f161)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @crazy-max @thaJeztah
    crazy-max authored and thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9674623 View commit details
    Browse the repository at this point in the history

  5. hack: remove unnecessary vars in make.sh script 

    Signed-off-by: CrazyMax <[email protected]>
(cherry picked from commit 877baae)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @crazy-max @thaJeztah
    crazy-max authored and thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    b7e0725 View commit details
    Browse the repository at this point in the history

  6. hack: display build cmd when DOCKER_DEBUG set 

    Signed-off-by: CrazyMax <[email protected]>
(cherry picked from commit 170a1c4)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @crazy-max @thaJeztah
    crazy-max authored and thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    699e853 View commit details
    Browse the repository at this point in the history

  7. vendor: github.com/pelletier/go-toml v1.9.5 

    Contains a fix that prevents a panic on an invalid toml file.

full diff: pelletier/go-toml@v1.9.4...v1.9.5

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 2209874)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    63a0f1f View commit details
    Browse the repository at this point in the history

  8. vendor: github.com/containerd/containerd v1.6.16 

    Notable Updates

- Fix push error propagation
- Fix slice append error with HugepageLimits for Linux
- Update default seccomp profile for PKU and CAP_SYS_NICE
- Fix overlayfs error when upperdirlabel option is set

full diff: containerd/containerd@v1.6.15...v1.6.16

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit c41c8c2)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    610250f View commit details
    Browse the repository at this point in the history

  9. Merge pull request #44881 from thaJeztah/23.0_containerd_binary_1.6.16 

    [23.0] update containerd binary to v1.6.16
    @AkihiroSuda
    AkihiroSuda authored Jan 30, 2023
    Configuration menu
    Copy the full SHA
    20203f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Merge pull request #44884 from thaJeztah/23.0_backport_rm_install_suffix 

    [23.0 backport] hack: remove -installsuffix build flag
    @thaJeztah
    thaJeztah authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    de3f216 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #44883 from thaJeztah/23.0_backport_invalid_character 

    [23.0 backport] client: improve error messaging on crash
    @thaJeztah
    thaJeztah authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    9df87ea View commit details
    Browse the repository at this point in the history

  3. Merge pull request #44885 from thaJeztah/23.0_backport_update_containerd 

    [23.0 backport] vendor: github.com/containerd/containerd v1.6.16
    @thaJeztah
    thaJeztah authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    d7573ab View commit details
    Browse the repository at this point in the history
Loading