-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Comparing changes
Open a pull request
base repository: moby/moby
base: v1.10.2
head repository: hallyn/docker
compare: v1.10.0.serge.2
- 6 commits
- 12 files changed
- 1 contributor
Commits on Feb 16, 2016
-
Do not create devices when in user namespace
When we launch a container in a new user namespace, we cannot create devices, so we bind mount the host's devices into place instead. If we are running in a user namespace (i.e. nested in a container), then we need to do the same thing. Add a function to detect that and check for it before doing mknod. Signed-off-by: Serge Hallyn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d81b659 - Browse repository at this point
Copy the full SHA d81b659View commit details -
Do not allow access to /dev/tty{0,1}
These are the real host devices, container should not generally have or need them. Signed-off-by: Serge Hallyn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9998ce - Browse repository at this point
Copy the full SHA f9998ceView commit details -
Don't create devices if in a user namespace
If we are running in a user namespace, don't try to mknod as it won't be allowed. libcontainer will bind-mount the host's devices over files in the container anyway, so it's not needed. Signed-off-by: Serge Hallyn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 78f5e69 - Browse repository at this point
Copy the full SHA 78f5e69View commit details -
archive: Don't create devices if in a user namespace
The chrootarchive package does a chroot (without mounting /proc) before its work, so we cannot check /proc/self/uid_map when we need to. So compute it in advance and pass it along with the tar options. Signed-off-by: Serge Hallyn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b019404 - Browse repository at this point
Copy the full SHA b019404View commit details -
Do not set devices cgroup entries if in a user namespace
kernel won't allow it. Signed-off-by: Serge Hallyn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 832031a - Browse repository at this point
Copy the full SHA 832031aView commit details
Commits on Feb 25, 2016
-
cgroup namespaces: ignore the mount.Root if we have cgroup namespaces
We should do this in a better way, in particular by verifying through /proc/self/cgroup whether the mount.Root is our cgroup prefix, but this suffices at the moment: if we have cgroup namespaces and are running inside an lxc or lxd container, the mount prefix will always be wrong. Signed-off-by: Serge Hallyn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ab8e54b - Browse repository at this point
Copy the full SHA ab8e54bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.10.2...v1.10.0.serge.2