Signed-off-by: Derek McGowan <[email protected]>

After the untar errors, the reader must complete in order to fill
the buffer used by the subsequent check.

Signed-off-by: Derek McGowan <[email protected]>

Cleanup decompress logic and add a pool. The close logic should be
custom defined for each compression type since they have different
close interfaces.

Signed-off-by: Derek McGowan <[email protected]>

The use of bufio for writing without flushing can lead to an incomplete
writing of the tar and subsequent unexpected EOF when importing.

Signed-off-by: Derek McGowan <[email protected]>

Remove use of `pkg/pools` in archive

This type was originally in pkg/transport, but got moved to pkg/ioutils
in 276c640.

This type is only used in a single location, and has no external consumers,
so we can move it where it's used and un-export it.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

This package was only used internally in container/streams and had
no external consumers.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Signed-off-by: Sebastiaan van Stijn <[email protected]>

relates to 56eb47c, which added
the "slices" package.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

These tests failed because the error message changed in go1.24 through
https://go.dev/cl/606956.

    === Failed
    === FAIL: daemon/config TestDaemonConfigurationFeatures/invalid_config_value (0.00s)
        config_linux_test.go:182: assertion failed: expected error "json: cannot unmarshal string into Go struct field Config.features of type bool", got "json: cannot unmarshal string into Go struct field Config.CommonConfig.features of type bool"

    === FAIL: daemon/config TestDaemonConfigurationFeatures (0.00s)

    === FAIL: daemon/config TestDaemonConfigurationHostGatewayIP/config_not_array (0.00s)
        config_linux_test.go:354: assertion failed: expected error "json: cannot unmarshal string into Go struct field Config.host-gateway-ips of type []netip.Addr", got "json: cannot unmarshal string into Go struct field Config.CommonConfig.DNSConfig.host-gateway-ips of type []netip.Addr"

Relax the tests a bit to accept errors produced by either go1.24 or older.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

pkg/ioutils: remove OnEOFReader and move it internal

daemon: parseSecurityOpt: rename var that shadowed function

pkg/parsers: rename var that collided with builtin

daemon: add missing "//go:build" directive

daemon: adjust tests for changes in go1.24 JSON errors

remove pkg/broadcaster and make it internal to container/streams