Add quoted string flag Value.

dnephin · dnephin · commit e4c1f0772923 · 2017-01-03T15:09:54.000-05:00
Signed-off-by: Daniel Nephin &lt;dnephin@docker.com&gt;
diff --git a/opts/quotedstring.go b/opts/quotedstring.go
@@ -0,0 +1,30 @@
+package opts
+
+// QuotedString is a string that may have extra quotes around the value. The
+// quotes are stripped from the value.
+type QuotedString string
+
+// Set sets a new value
+func (s *QuotedString) Set(val string) error {
+	*s = QuotedString(trimQuotes(val))
+	return nil
+}
+
+// Type returns the type of the value
+func (s *QuotedString) Type() string {
+	return "string"
+}
+
+func (s *QuotedString) String() string {
+	return string(*s)
+}
+
+func trimQuotes(value string) string {
+	lastIndex := len(value) - 1
+	for _, char := range []byte{'\'', '"'} {
+		if value[0] == char && value[lastIndex] == char {
+			return value[1:lastIndex]
+		}
+	}
+	return value
+}
diff --git a/opts/quotedstring_test.go b/opts/quotedstring_test.go
@@ -0,0 +1,24 @@
+package opts
+
+import (
+	"github.com/docker/docker/pkg/testutil/assert"
+	"testing"
+)
+
+func TestQuotedStringSetWithQuotes(t *testing.T) {
+	qs := QuotedString("")
+	assert.NilError(t, qs.Set("\"something\""))
+	assert.Equal(t, qs.String(), "something")
+}
+
+func TestQuotedStringSetWithMismatchedQuotes(t *testing.T) {
+	qs := QuotedString("")
+	assert.NilError(t, qs.Set("\"something'"))
+	assert.Equal(t, qs.String(), "\"something'")
+}
+
+func TestQuotedStringSetWithNoQuotes(t *testing.T) {
+	qs := QuotedString("")
+	assert.NilError(t, qs.Set("something"))
+	assert.Equal(t, qs.String(), "something")
+}
