registry: deprecate APIEndpoint.Official field

thaJeztah · thaJeztah · commit d8fa2f807103 · 2025-03-27T15:00:39.000+01:00
This field was introduced in 19515a7 when the registry code was replaced for code vendored from docker/distribution. It was used for v1 registries to update the "TrustStore" for signed manifests; https://github.com/moby/moby/blob/19515a7ad859b28c474d81e756ac245afcd968e3/graph/pull.go#L89-L93 Before that, it used the IndexInfo.Official field; https://github.com/moby/moby/blob/276c640be4b4335e3b8d684cb3562a56d3337b39/graph/pull.go#L94-L97 And related to "v2" registries; 88fdcfe Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/registry/service.go b/registry/service.go
@@ -115,7 +115,7 @@ type APIEndpoint struct {
 	Mirror                         bool
 	URL                            *url.URL
 	AllowNondistributableArtifacts bool // Deprecated: non-distributable artifacts are deprecated and enabled by default. This field will be removed in the next release.
-	Official                       bool
+	Official                       bool // Deprecated: this field was only used internally, and will be removed in the next release.
 	TrimHostname                   bool // Deprecated: hostname is now trimmed unconditionally for remote names. This field will be removed in the next release.
 	TLSConfig                      *tls.Config
 }

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ type APIEndpoint struct {`
`115`	`115`	`Mirror bool`
`116`	`116`	`URL *url.URL`
`117`	`117`	`AllowNondistributableArtifacts bool // Deprecated: non-distributable artifacts are deprecated and enabled by default. This field will be removed in the next release.`
`118`		`- Official bool`
	`118`	`+ Official bool // Deprecated: this field was only used internally, and will be removed in the next release.`
`119`	`119`	`TrimHostname bool // Deprecated: hostname is now trimmed unconditionally for remote names. This field will be removed in the next release.`
`120`	`120`	`TLSConfig *tls.Config`
`121`	`121`	`}`