api/types/plugin: deprecate Config.DockerVersion field

thaJeztah · thaJeztah · commit c4fda95beaee · 2025-10-06T14:19:53.000+02:00
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/api/docs/CHANGELOG.md b/api/docs/CHANGELOG.md
@@ -74,6 +74,9 @@ keywords: "API, Docker, rcli, REST, documentation"
   continues returning these fields when set for informational purposes, but
   they should not be depended on as they will be omitted once the legacy builder
   is removed.
+* Deprecated: the `Config.DockerVersion` field returned by the `GET /plugins`
+  and `GET /images/{name}/json` endpoints is deprecated. The field is no
+  longer set, and is omitted when empty.
 
 ## v1.50 API changes
 
diff --git a/api/docs/v1.51.yaml b/api/docs/v1.51.yaml
@@ -3142,10 +3142,15 @@ definitions:
           - Args
         properties:
           DockerVersion:
-            description: "Docker Version used to create the plugin"
+            description: |-
+              Docker Version used to create the plugin.
+
+              Depending on how the plugin was created, this field may be empty or omitted.
+
+              Deprecated: this field is no longer set, and will be removed in the next API version.
             type: "string"
             x-nullable: false
-            example: "17.06.0-ce"
+            x-omitempty: true
           Description:
             type: "string"
             x-nullable: false
diff --git a/api/docs/v1.52.yaml b/api/docs/v1.52.yaml
@@ -3203,10 +3203,15 @@ definitions:
           - Args
         properties:
           DockerVersion:
-            description: "Docker Version used to create the plugin"
+            description: |-
+              Docker Version used to create the plugin.
+
+              Depending on how the plugin was created, this field may be empty or omitted.
+
+              Deprecated: this field is no longer set, and will be removed in the next API version.
             type: "string"
             x-nullable: false
-            example: "17.06.0-ce"
+            x-omitempty: true
           Description:
             type: "string"
             x-nullable: false
diff --git a/api/swagger.yaml b/api/swagger.yaml
@@ -3203,10 +3203,15 @@ definitions:
           - Args
         properties:
           DockerVersion:
-            description: "Docker Version used to create the plugin"
+            description: |-
+              Docker Version used to create the plugin.
+
+              Depending on how the plugin was created, this field may be empty or omitted.
+
+              Deprecated: this field is no longer set, and will be removed in the next API version.
             type: "string"
             x-nullable: false
-            example: "17.06.0-ce"
+            x-omitempty: true
           Description:
             type: "string"
             x-nullable: false
diff --git a/api/types/plugin/plugin.go b/api/types/plugin/plugin.go
diff --git a/daemon/pkg/plugin/backend_linux.go b/daemon/pkg/plugin/backend_linux.go
@@ -707,7 +707,7 @@ func (pm *Manager) CreateFromContext(ctx context.Context, tarCtx io.ReadCloser,
 		DiffIds: []string{rootFSBlob.Digest().String()},
 	}
 
-	config.DockerVersion = dockerversion.Version
+	config.DockerVersion = dockerversion.Version //nolint:staticcheck // ignore SA1019: field is deprecated.
 
 	configBlob, err := pm.blobStore.Writer(ctx, content.WithRef(name+"-config.json"))
 	if err != nil {
diff --git a/vendor/github.com/moby/moby/api/types/plugin/plugin.go b/vendor/github.com/moby/moby/api/types/plugin/plugin.go

Original file line number	Diff line number	Diff line change
`@@ -707,7 +707,7 @@ func (pm *Manager) CreateFromContext(ctx context.Context, tarCtx io.ReadCloser,`
`707`	`707`	`DiffIds: []string{rootFSBlob.Digest().String()},`
`708`	`708`	`}`
`709`	`709`
`710`		`- config.DockerVersion = dockerversion.Version`
	`710`	`+ config.DockerVersion = dockerversion.Version //nolint:staticcheck // ignore SA1019: field is deprecated.`
`711`	`711`
`712`	`712`	`configBlob, err := pm.blobStore.Writer(ctx, content.WithRef(name+"-config.json"))`
`713`	`713`	`if err != nil {`