Skip to content

Commit bd3cf1e

Browse files
committed
ServiceConfig: log errors when loading config
Log errors when the config is loaded to notify the user of any errors, for instance, when a specified mirror has an invalid URL. Signed-off-by: Valentin Rothberg <[email protected]>
1 parent e23965d commit bd3cf1e

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

registry/config.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,15 @@ func newServiceConfig(options ServiceOptions) *serviceConfig {
8282
V2Only: options.V2Only,
8383
}
8484

85-
config.LoadAllowNondistributableArtifacts(options.AllowNondistributableArtifacts)
86-
config.LoadMirrors(options.Mirrors)
87-
config.LoadInsecureRegistries(options.InsecureRegistries)
85+
if err := config.LoadAllowNondistributableArtifacts(options.AllowNondistributableArtifacts); err != nil {
86+
logrus.Warnf("error loading non-distributable artifacts: %v", err)
87+
}
88+
if err := config.LoadMirrors(options.Mirrors); err != nil {
89+
logrus.Warnf("error loading mirrors: %v", err)
90+
}
91+
if err := config.LoadInsecureRegistries(options.InsecureRegistries); err != nil {
92+
logrus.Warnf("error loading insecure registries: %v", err)
93+
}
8894

8995
return config
9096
}

0 commit comments

Comments
 (0)