registry: deprecate RepositoryInfo.Class

thaJeztah · thaJeztah · commit 5f91c769f54f · 2024-11-30T14:31:18.000+01:00
The Class field was added in a12b466 because Docker Hub registry required a special scope to be set for pulling plugins; HTTP/1.1 401 Unauthorized ... Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io",scope="repository(plugin):vieux/sshfs:pull",error="insufficient_scope" This is no longer a requirement, and the field is no longer set. This patch deprecates the field and removes its use. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/distribution/registry.go b/distribution/registry.go
@@ -123,7 +123,6 @@ func newRepository(
 			Scopes: []auth.Scope{auth.RepositoryScope{
 				Repository: repoName,
 				Actions:    actions,
-				Class:      repoInfo.Class,
 			}},
 			ClientID: registry.AuthClientID,
 		})
diff --git a/registry/types.go b/registry/types.go
@@ -37,5 +37,7 @@ type RepositoryInfo struct {
 	Official bool
 	// Class represents the class of the repository, such as "plugin"
 	// or "image".
+	//
+	// Deprecated: this field is no longer used, and will be removed in the next release.
 	Class string
 }

Original file line number	Diff line number	Diff line change
`@@ -37,5 +37,7 @@ type RepositoryInfo struct {`
`37`	`37`	`Official bool`
`38`	`38`	`// Class represents the class of the repository, such as "plugin"`
`39`	`39`	`// or "image".`
	`40`	`+ //`
	`41`	`+ // Deprecated: this field is no longer used, and will be removed in the next release.`
`40`	`42`	`Class string`
`41`	`43`	`}`