Add cli build warning about chmod bits on windows

ahmetb · ahmetb · commit 4a8b3cad6096 · 2015-03-20T20:13:32.000Z
This shows a warning message about adjusted file/directory permission bits
when the `docker build` cli command is executed on windows.

Signed-off-by: Ahmet Alp Balkan &lt;ahmetalpbalkan@gmail.com&gt;
diff --git a/api/client/commands.go b/api/client/commands.go
@@ -227,6 +227,13 @@ func (cli *DockerCli) CmdBuild(args ...string) error {
 			return err
 		}
 	}
+
+	// windows: show error message about modified file permissions
+	// FIXME: this is not a valid warning when the daemon is running windows. should be removed once docker engine for windows can build.
+	if runtime.GOOS == "windows" {
+		log.Warn(`SECURITY WARNING: You are building a Docker image from Windows against a Linux Docker host. All files and directories added to build context will have '-rwxr-xr-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.`)
+	}
+
 	var body io.Reader
 	// Setup an upload progress bar
 	// FIXME: ProgressReader shouldn't be this annoying to use
diff --git a/integration-cli/docker_cli_build_test.go b/integration-cli/docker_cli_build_test.go
@@ -4551,8 +4551,19 @@ func TestBuildStderr(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if stderr != "" {
-		t.Fatalf("Stderr should have been empty, instead its: %q", stderr)
+
+	if runtime.GOOS == "windows" {
+		// stderr might contain a security warning on windows
+		lines := strings.Split(stderr, "\n")
+		for _, v := range lines {
+			if v != "" && !strings.Contains(v, "SECURITY WARNING:") {
+				t.Fatalf("Stderr contains unexpected output line: %q", v)
+			}
+		}
+	} else {
+		if stderr != "" {
+			t.Fatalf("Stderr should have been empty, instead its: %q", stderr)
+		}
 	}
 	logDone("build - testing stderr")
 }

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,13 @@ func (cli *DockerCli) CmdBuild(args ...string) error {`
`227`	`227`	`return err`
`228`	`228`	`}`
`229`	`229`	`}`
	`230`	`+`
	`231`	`+ // windows: show error message about modified file permissions`
	`232`	`+ // FIXME: this is not a valid warning when the daemon is running windows. should be removed once docker engine for windows can build.`
	`233`	`+ if runtime.GOOS == "windows" {`
	`234`	+ log.Warn(`SECURITY WARNING: You are building a Docker image from Windows against a Linux Docker host. All files and directories added to build context will have '-rwxr-xr-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.`)
	`235`	`+ }`
	`236`	`+`
`230`	`237`	`var body io.Reader`
`231`	`238`	`// Setup an upload progress bar`
`232`	`239`	`// FIXME: ProgressReader shouldn't be this annoying to use`