daemon/command: don't make notifyReady(), notifyStopping() asynchronous

thaJeztah · corhere · commit 236fc46b5a71 · 2026-02-03T12:24:08.000-05:00
Leave it to the consumer to decide whether these should be called in a
goroutine.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/daemon/command/daemon.go b/daemon/command/daemon.go
@@ -336,7 +336,7 @@ func (cli *daemonCLI) start(ctx context.Context) (err error) {
 	cli.setupConfigReloadTrap()
 
 	// after the daemon is done setting up we can notify systemd api
-	notifyReady()
+	go notifyReady()
 	log.G(ctx).Info("Daemon has completed initialization")
 
 	// Daemon is fully initialized. Start handling API traffic
@@ -369,7 +369,7 @@ func (cli *daemonCLI) start(ctx context.Context) (err error) {
 	c.Cleanup()
 
 	// notify systemd that we're shutting down
-	notifyStopping()
+	go notifyStopping()
 	shutdownDaemon(ctx, d)
 
 	// shutdown / close BuildKit backend
diff --git a/daemon/command/daemon_linux.go b/daemon/command/daemon_linux.go
@@ -50,12 +50,12 @@ func preNotifyReady() error {
 // notifyReady sends a message to the host when the server is ready to be used
 func notifyReady() {
 	// Tell the init daemon we are accepting requests
-	go systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyReady)
+	_, _ = systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyReady)
 }
 
 // notifyStopping sends a message to the host when the server is shutting down
 func notifyStopping() {
-	go systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyStopping)
+	_, _ = systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyStopping)
 }
 
 func validateCPURealtimeOptions(cfg *config.Config) error {

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,12 @@ func preNotifyReady() error {`
`50`	`50`	`// notifyReady sends a message to the host when the server is ready to be used`
`51`	`51`	`func notifyReady() {`
`52`	`52`	`// Tell the init daemon we are accepting requests`
`53`		`- go systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyReady)`
	`53`	`+ _, _ = systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyReady)`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`// notifyStopping sends a message to the host when the server is shutting down`
`57`	`57`	`func notifyStopping() {`
`58`		`- go systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyStopping)`
	`58`	`+ _, _ = systemdDaemon.SdNotify(false, systemdDaemon.SdNotifyStopping)`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`func validateCPURealtimeOptions(cfg *config.Config) error {`