c8d/pull: Output truncated id for Pulling fs layer

vvoland · vvoland · commit 16aa7dd67fc2 · 2024-02-27T11:09:16.000+01:00
All other progress updates are emitted with truncated id.

```diff
$ docker pull --platform linux/amd64 alpine
Using default tag: latest
latest: Pulling from library/alpine
-sha256:4abcf20661432fb2d719aaf90656f55c287f8ca915dc1c92ec14ff61e67fbaf8: Pulling fs layer
+4abcf2066143: Download complete
Digest: sha256:c5b1261d6d3e43071626931fc004f70149baeba2c8ec672bd4f27761f8e1ad6b
Status: Image is up to date for alpine:latest
docker.io/library/alpine:latest
```

Signed-off-by: Paweł Gronowski &lt;pawel.gronowski@docker.com&gt;
diff --git a/daemon/containerd/image_pull.go b/daemon/containerd/image_pull.go
@@ -21,6 +21,7 @@ import (
 	"github.com/docker/docker/internal/compatcontext"
 	"github.com/docker/docker/pkg/progress"
 	"github.com/docker/docker/pkg/streamformatter"
+	"github.com/docker/docker/pkg/stringid"
 	ocispec "github.com/opencontainers/image-spec/specs-go/v1"
 	"github.com/pkg/errors"
 )
@@ -118,7 +119,8 @@ func (i *ImageService) pullTag(ctx context.Context, ref reference.Named, platfor
 			sentSchema1Deprecation = true
 		}
 		if images.IsLayerType(desc.MediaType) {
-			progress.Update(out, desc.Digest.String(), "Pulling fs layer")
+			id := stringid.TruncateID(desc.Digest.String())
+			progress.Update(out, id, "Pulling fs layer")
 		}
 		if images.IsManifestType(desc.MediaType) {
 			if !sentPullingFrom {

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ import (`
`21`	`21`	`"github.com/docker/docker/internal/compatcontext"`
`22`	`22`	`"github.com/docker/docker/pkg/progress"`
`23`	`23`	`"github.com/docker/docker/pkg/streamformatter"`
	`24`	`+ "github.com/docker/docker/pkg/stringid"`
`24`	`25`	`ocispec "github.com/opencontainers/image-spec/specs-go/v1"`
`25`	`26`	`"github.com/pkg/errors"`
`26`	`27`	`)`
`@@ -118,7 +119,8 @@ func (i *ImageService) pullTag(ctx context.Context, ref reference.Named, platfor`
`118`	`119`	`sentSchema1Deprecation = true`
`119`	`120`	`}`
`120`	`121`	`if images.IsLayerType(desc.MediaType) {`
`121`		`- progress.Update(out, desc.Digest.String(), "Pulling fs layer")`
	`122`	`+ id := stringid.TruncateID(desc.Digest.String())`
	`123`	`+ progress.Update(out, id, "Pulling fs layer")`
`122`	`124`	`}`
`123`	`125`	`if images.IsManifestType(desc.MediaType) {`
`124`	`126`	`if !sentPullingFrom {`