Fixed public pull + Added some verbosity about what is happening

samalba · shin- · commit 00266df8ac64 · 2013-05-06T10:57:45.000-07:00
diff --git a/registry.go b/registry.go
@@ -269,7 +269,7 @@ func (graph *Graph) PullRepository(stdout io.Writer, remote, askedTag string, re
 	if err != nil {
 		return err
 	}
-	if authConfig != nil {
+	if authConfig != nil && len(authConfig.Username) > 0 {
 		req.SetBasicAuth(authConfig.Username, authConfig.Password)
 	}
 	req.Header.Set("X-Docker-Token", "true")
@@ -309,6 +309,7 @@ func (graph *Graph) PullRepository(stdout io.Writer, remote, askedTag string, re
 	}
 
 	for askedTag, imgId := range tagsList {
+		fmt.Fprintf(stdout, "Resolving tag \"%s:%s\" from %s\n", remote, askedTag, endpoints)
 		success := false
 		for _, registry := range endpoints {
 			if imgId == "" {

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ func (graph *Graph) PullRepository(stdout io.Writer, remote, askedTag string, re`
`269`	`269`	`if err != nil {`
`270`	`270`	`return err`
`271`	`271`	`}`
`272`		`- if authConfig != nil {`
	`272`	`+ if authConfig != nil && len(authConfig.Username) > 0 {`
`273`	`273`	`req.SetBasicAuth(authConfig.Username, authConfig.Password)`
`274`	`274`	`}`
`275`	`275`	`req.Header.Set("X-Docker-Token", "true")`
`@@ -309,6 +309,7 @@ func (graph *Graph) PullRepository(stdout io.Writer, remote, askedTag string, re`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`for askedTag, imgId := range tagsList {`
	`312`	`+ fmt.Fprintf(stdout, "Resolving tag \"%s:%s\" from %s\n", remote, askedTag, endpoints)`
`312`	`313`	`success := false`
`313`	`314`	`for _, registry := range endpoints {`
`314`	`315`	`if imgId == "" {`