Change in bridge/setup_ip_tables.go#670
Merged
mavenugo merged 1 commit intomoby:masterfrom Mar 15, 2016
aboch:it
Merged
Conversation
- With the transition to ipam, bridge ip address stored in `bridgeInterface` is guaranteed to be the ip of the OS bridge by the `setupBridgeIPv4` step function. Therefore the `setupIPTables()` step function no longer needs to fetch the address from the OS. Signed-off-by: Alessandro Boch <[email protected]>
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
mavenugo
added a commit
that referenced
this pull request
Mar 15, 2016
Change in bridge/setup_ip_tables.go
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Feb 9, 2023
- GetIfaceAddr is unused since moby/libnetwork#670 - ValidateAlias and ParseAlias are unused since moby#42539 Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Feb 16, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Feb 16, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 2, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 2, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 6, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 31, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 31, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Apr 6, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in
bridgeInterfaceis guaranteed to be the ip of theOS bridge by the
setupBridgeIPv4step function.Therefore the
setupIPTables()step function nolonger needs to fetch the address from the OS.
This removes unnecessary syscalls to the OS
and removes the code which may cause confusion.
Signed-off-by: Alessandro Boch [email protected]