Conversation
etcd v2.0+ with API v2 cannot watch on a regular key, we must enforce the 'IsDir' parameter while creating the key for it to be considered as a directory. This step is necessary unless 'libkv' includes and supports the new etcd API v3 which removes the directory/key distinction to allow for a better abstraction. Fixes: moby#392 See: docker/libkv#20 Signed-off-by: Alexandre Beslic <[email protected]>
|
depends on docker/libkv#75 |
|
@mavenugo What needs to happen for this to get merged? The libkv changes have been merged so do you just need to tell circleCI to run the tests again? |
|
@abronan We don't do any |
|
@mrjana good point... forgot about it :) |
|
@abronan btw, do we need to upgrade the libkv version in libnetwork in order to use the latest etcd client ? Will that get us anything that is not already available in the current version ? |
|
@mavenugo It will get you nothing if you don't use |
4 participants
etcd v2.0+ with API v2 cannot watch on a regular key, we must enforce
the 'IsDir' parameter while creating the key for it to be considered
as a directory.
This step is necessary unless 'libkv' includes and supports the new
etcd API v3 which removes the directory/key distinction to allow for
a better abstraction.
Fixes: #392
See: docker/libkv#20
Signed-off-by: Alexandre Beslic [email protected]