Skip to content

Revert: Added API to set ephemeral port allocator range#2668

Merged
thaJeztah merged 1 commit into
moby:masterfrom
sbuckfelder:BACKPORT
Nov 10, 2022
Merged

Revert: Added API to set ephemeral port allocator range#2668
thaJeztah merged 1 commit into
moby:masterfrom
sbuckfelder:BACKPORT

Conversation

@sbuckfelder

Copy link
Copy Markdown
Contributor

Signed-off-by: Scott Buckfelder [email protected]

Warning
libnetwork was moved to https://github.com/moby/moby/tree/master/libnetwork

libnetwork has been merged to the main repo of Moby since Docker 22.06.

The old libnetwork repo (https://github.com/moby/libnetwork) now only accepts PR for Docker 20.10,
and will be archived after the EOL of Docker 20.10.

Reference Issue : moby/moby#44423

This PR backports the current behavior in moby/moby to 20.10. The PR for master is #43066

Testing

Ran make and make unit-tests. The unit tests had one failure that also exists in the master branch

--- FAIL: TestDNSOptions (0.16s)
    service_common_test.go:65: assertion failed: expected [timeout:2 attempts:5 ndots:0] (length 3) to have length 1
    service_common_test.go:66: assertion failed: ndots:0 (string) != timeout:2 (dnsOptionsList[0] string)

@sbuckfelder

Copy link
Copy Markdown
Contributor Author

Instrumental in the initial PR:
@akerouanton
@thaJeztah

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants