Ipamutils: various cleanups and refactor#2593
Closed
thaJeztah wants to merge 4 commits intomoby:masterfrom
Closed
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
The `GetLocalScopeDefaultNetworks()` and `GetGlobalScopeDefaultNetworks()` protect these variables with a lock, but various parts in the code were directly accessing the variables without locks. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This package defines the `NetworkToSplit` type. Curently importing the package also initializes the default address pools (which may not be needed, e.g., when used in the client. This patch changes initialization to happen on first use, instead of `init()`, to allow the package to be imported without initializing these pools. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
arkodg
reviewed
Nov 3, 2020
| Size int `json:"size"` | ||
| } | ||
|
|
||
| func init() { |
Contributor
There was a problem hiding this comment.
isn't init easier to reason with than initDefaults ?
Member
Author
There was a problem hiding this comment.
You mean "using an init() function"? Or to rename the initDefaults (sync.Once) to init? (not sure if the latter works; I suspect init is somewhat "reserved"))
sloppyjuicy
approved these changes
Jun 15, 2021
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetLocalScopeDefaultNetworks()andGetGlobalScopeDefaultNetworks()protect these variables with a lock, but various parts in the code were directly accessing the variables without locks.This package defines the
NetworkToSplittype. Curently importing the package also initializes the default address pools (which may not be needed, e.g., when used in the client.This patch changes initialization to happen on first use, instead of
init(), to allow the package to be imported without initializing these pools.