[19.03 backport] resolver panic backport#2541
Merged
thaJeztah merged 1 commit intomoby:bump_19.03from Mar 19, 2020
SamWhited:19.03_resolver_panic_backport
Merged
[19.03 backport] resolver panic backport#2541thaJeztah merged 1 commit intomoby:bump_19.03from SamWhited:19.03_resolver_panic_backport
thaJeztah merged 1 commit intomoby:bump_19.03from
SamWhited:19.03_resolver_panic_backport
Conversation
Contributor
|
once the master commit has been committed can you please use |
Contributor
Author
|
Oh nifty, I wasn't aware of the -x option. Will do. |
Under certain conditions it appears that the DNS response and returned error can be nil. When this happens, checking resp.Truncated results in a nil panic so we must first check that the response is not nil before checking if a truncated response was received. See moby/moby#40715 Signed-off-by: Sam Whited <[email protected]> (cherry picked from commit bea32b0)
Contributor
Author
|
Re-cherry-picked again to make tests pass. Everything seems green now. /cc @thaJeztah |
SamWhited
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2540