Fixes a panic in the DNS resolver#2540
Merged
arkodg merged 1 commit intomoby:masterfrom Mar 18, 2020
SamWhited:resolver_panic
Merged
Fixes a panic in the DNS resolver#2540arkodg merged 1 commit intomoby:masterfrom SamWhited:resolver_panic
arkodg merged 1 commit intomoby:masterfrom
SamWhited:resolver_panic
Conversation
thaJeztah
reviewed
Mar 18, 2020
Contributor
Author
|
Tests passing! |
Contributor
|
LGTM on the fix, can you please add a better description in the commit message @SamWhited |
Under certain conditions it appears that the DNS response and returned error can be nil. When this happens, checking resp.Truncated results in a nil panic so we must first check that the response is not nil before checking if a truncated response was received. See moby/moby#40715 Signed-off-by: Sam Whited <[email protected]>
Contributor
Author
|
Added a paragraph explaining what changed. |
Member
|
did you re-cherry-pick the 19.03 backport as well? |
Contributor
Author
|
Sure did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See moby/moby#40715