Fixed getNetworkFromStore, which returned an incorrect struct#2449
Fixed getNetworkFromStore, which returned an incorrect struct#2449selansen merged 2 commits intomoby:masterfrom
Conversation
…on - notably, the 'resolver' field was empty. This fixes moby/moby#38901 Signed-off-by: Espen Suenson <[email protected]>
|
@thaJeztah any chance that this PR will be looked at soon? We cannot use docker networks for continuous integration until the associated bug is fixed. |
vikramhh
left a comment
vikramhh
left a comment
There was a problem hiding this comment.
Possibly we should return immediately after line 83 in case of error. Otherwise an empty map iteration would lead to "network not found" error being returned instead of the actual error from getNetworksFromStore.
|
Please sign your commits following these rules: $ git clone -b "bugfix_getnetworkfromstore" [email protected]:espensuenson/libnetwork.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354325096
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Espen Suenson <[email protected]>
espensuenson
force-pushed
the
bugfix_getnetworkfromstore
branch
from
8877bee to
a35a770
Compare
|
@vikramhh I changed it to return immediately in case of error. |
|
@espensuenson - thanks. LGTM |
Issues that are fixed : log the actual error when failing to add IPv6 route moby/libnetwork#2444 Shorten controller ID in exec-root to not hit UNIX_PATH_MAX moby/libnetwork#2443 Fixed getNetworkFromStore, which returned an incorrect struct moby/libnetwork#2449 weighted scheduling methods constants for ipvs moby/libnetwork#2453 Resolve "bridge fdb show" hang issue moby/libnetwork#2456 Signed-off-by: Espen Suenson <[email protected]>
5 participants
Fixed getNetworkFromStore, which returned incorrect network information - notably, the 'resolver' field was empty.
This fixes moby/moby#38901
Signed-off-by: Espen Suenson [email protected]