(windows) Pick a random host port if the user does not specify a host port. #2368
(windows) Pick a random host port if the user does not specify a host port. #2368mavenugo merged 1 commit intomoby:masterfrom
Conversation
|
@mavenugo PTAL. |
pradipd
force-pushed
the
WindowsPortMappingFix
branch
2 times, most recently
from
7e6982e to
43a5636
Compare
For overlay, l2bridge, and l2tunnel, if the user does not specify a host port, windows driver will select a random port for them. This matches linux behavior. For ics and nat networks the windows OS will choose the port. Signed-off-by: Pradip Dhara <[email protected]>
pradipd
force-pushed
the
WindowsPortMappingFix
branch
from
43a5636 to
e6b4a7a
Compare
|
Looks like unit tests still failing. Looking to get this backported to bump_18.09 when this PR is ready. |
|
I can't get a local repro. I'm running on Ubuntu 16.04. What do I need to do to move past this? |
|
Could someone restart CI on this one, or could this be an actual issue? If this is due to flakiness / slow runs, there's a configuration option to extend the timeout (see docker/cli#1750, where I raised it for docker/cli) |
|
I restarted the CI again. The flakiness doesnt seem to be related. But let me give it another go. |
|
CI is green now 👍 |
|
|
||
| const ( | ||
| StartPortRange = 60000 | ||
| EndPortRange = 65000 |
There was a problem hiding this comment.
Looks like these don't have to be exported
Also; given that constants are assigned for these, I assume there's no configurable ephemeral port range on Windows (as there's on Linux)?
There was a problem hiding this comment.
Looks like there is a configurable range; should that be used? https://support.microsoft.com/en-gb/help/929851/the-default-dynamic-port-range-for-tcp-ip-has-changed-in-windows-vista
full diff: moby/libnetwork@c902989...872f0a8 - moby/libnetwork#2354 [18.09 backport] Cleanup the cluster provider when the agent is closed - backport of moby/libnetwork#2307 Fix for problem where agent is stopped and does not restart - fixes docker/for-linux#495 Docker swarm overlay networking not working after --force-new-cluster - moby/libnetwork#2369 [18.09 BACKPORT] Pick a random host port if the user does not specify a host port - backport of moby/libnetwork#2368 (windows) Pick a random host port if the user does not specify a host port Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: moby/libnetwork@48f8463...9ff9b57 - moby/libnetwork#2368 (windows) Pick a random host port if the user does not specify a host port Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: moby/libnetwork@c902989...872f0a8 - moby/libnetwork#2354 [18.09 backport] Cleanup the cluster provider when the agent is closed - backport of moby/libnetwork#2307 Fix for problem where agent is stopped and does not restart - fixes docker/for-linux#495 Docker swarm overlay networking not working after --force-new-cluster - moby/libnetwork#2369 [18.09 BACKPORT] Pick a random host port if the user does not specify a host port - backport of moby/libnetwork#2368 (windows) Pick a random host port if the user does not specify a host port Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: 5354408039681020f9ad6afe4bf696fc90f9ce69 Component: engine
full diff: moby/libnetwork@48f8463...9ff9b57 - moby/libnetwork#2368 (windows) Pick a random host port if the user does not specify a host port Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: 7f2c564b23377e1c69bc06e40fef1a459d6f51b5 Component: engine
5 participants
For overlay, l2bridge, and l2tunnel, if the user does not specify a host port, windows driver will select a random port for them. This matches linux behavior.
For ics and nat networks the windows OS will choose the port.
Signed-off-by: Pradip Dhara [email protected]