Bump vishvananda/netlink to 1.0.0 by thaJeztah · Pull Request #2366 · moby/libnetwork

thaJeztah · 2019-04-10T13:48:51Z

Replaces #2118; rebase of the original PR with some changes removed that are already on master (or in a separate PR now) and also updates vishvananda/netns

closes #2118
closes #2304

Full diff: vishvananda/netlink@b2de5d1...v1.0.0

Changes included:

Allow index specification at link creation time vishvananda/netlink#283 Allow index specification at link creation time
replace syscall with golang.org/x/sys/unix vishvananda/netlink#286 replace syscall with golang.org/x/sys/unix
- related: Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE vishvananda/netlink#330 Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE
- related: Use IFLA_* constants from x/sys/unix vishvananda/netlink#332 Use IFLA_* constants from x/sys/unix
Fix index out of range when no metadata for gretap vishvananda/netlink#287 Fix index out of range when no metadata for gretap
added encapsulation attributes for Iptun and Sittun to support SIT tunnels vishvananda/netlink#281 added encapsulation attributes for Iptun and Sittun to support SIT tunnels
Expose xfrm state's statistics vishvananda/netlink#288 Expose xfrm state's statistics
Support invert in ip rules vishvananda/netlink#290 Support invert in ip rules
Support LWTUNNEL_ENCAP_SEG6 vishvananda/netlink#282 Support LWTUNNEL_ENCAP_SEG6
vishvananda/netlink@63ca7e4 Support setting and retrieving route MTU/AdvMSS
Fix CalcRtable array parameter bug vishvananda/netlink#259 Fix CalcRtable array parameter bug
added support for Foo-over-UDP netlink calls vishvananda/netlink#285 added support for Foo-over-UDP netlink calls
Support num{tx,rx}queues and udp6zerocsum{tx,rx} vishvananda/netlink#225 Support num{tx,rx}queues and udp6zerocsum{tx,rx}
tuntap: Add multiqueue support vishvananda/netlink#293 tuntap: Add multiqueue support
Retrieve VLAN ID when listing neighbour vishvananda/netlink#227 Retrieve VLAN ID when listing neighbour
Fix LinkAdd for sit tunnel on 3.10 kernel vishvananda/netlink#301 Fix LinkAdd for sit tunnel on 3.10 kernel
Add support for managing source MACVLANs vishvananda/netlink#303 Add support for managing source MACVLANs
Two functions: one for adding bond slave, one for getting veth peer index vishvananda/netlink#307 Two functions: one for adding bond slave, one for getting veth peer index
Eliminate cgo from netlink. vishvananda/netlink#308 Eliminate cgo from netlink
Don't overwrite the XDP file descriptor with flags vishvananda/netlink#309 Don't overwrite the XDP file descriptor with flags
Fix reference to BPF instructions vishvananda/netlink#313 Fix reference to BPF instructions (on Kernel 4.13)
Add Matchall filter vishvananda/netlink#311 Add Matchall filter
Send IFA_CACHEINFO when setting up addresses vishvananda/netlink#315 Send IFA_CACHEINFO when setting up addresses
Support IPv6 GRE Tun and Tap vishvananda/netlink#317 Support IPv6 GRE Tun and Tap
Add List option to RouteSubscribeWithOptions, AddrSubscribeWithOptions, and LinkSubscribeWithOptions. vishvananda/netlink#318 Add List option to RouteSubscribeWithOptions, AddrSubscribeWithOptions, and LinkSubscribeWithOptions
Add Fq and Fq_Codel Qdisc support vishvananda/netlink#321 Add Fq and Fq_Codel Qdisc support

thaJeztah · 2019-04-10T16:38:46Z

hm, something to revendor I guess;

# github.com/docker/libnetwork/cmd/dnet
cmd/dnet/dnet.go:353:39: undefined: unix.SIGTERM
cmd/dnet/dnet.go:353:53: undefined: unix.SIGQUIT

never mind; it's cross-compiling for Windows, so guess we can't switch to x/sys/unix for those; I'll drop one commit.

thaJeztah · 2019-04-10T16:55:42Z

whoop; all green.

@mavenugo @euanh @aboch PTAL

thaJeztah · 2019-04-10T17:19:11Z

opened a "WIP" pull request in moby to run CI there; moby/moby#39054

thaJeztah · 2019-04-10T19:58:50Z

Good news; moby/moby#39054 passed

thaJeztah · 2019-05-23T11:23:49Z

ping @arkodg @euanh @joeabbey ptal

arkodg

LGTM

thaJeztah · 2019-06-04T23:32:32Z

I'll rebase this one once the other PR is merged

Changes included: - Allow index specification at link creation time - replace syscall with golang.org/x/sys/unix - related: Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE - related: Use IFLA_* constants from x/sys/unix - Fix index out of range when no metadata for gretap - added encapsulation attributes for Iptun and Sittun to support SIT tunnels - Expose xfrm state's statistics - Support invert in ip rules - Support LWTUNNEL_ENCAP_SEG6 - Support setting and retrieving route MTU/AdvMSS - Fix CalcRtable array parameter bug - added support for Foo-over-UDP netlink calls - Support num{tx,rx}queues and udp6zerocsum{tx,rx} - tuntap: Add multiqueue support - Retrieve VLAN ID when listing neighbour - Fix LinkAdd for sit tunnel on 3.10 kernel - Add support for managing source MACVLANs - Two functions: one for adding bond slave, one for getting veth peer index - Eliminate cgo from netlink - Don't overwrite the XDP file descriptor with flags - Fix reference to BPF instructions (on Kernel 4.13) - Add Matchall filter - Send IFA_CACHEINFO when setting up addresses - Support IPv6 GRE Tun and Tap - Add List option to RouteSubscribeWithOptions, AddrSubscribeWithOptions, and LinkSubscribeWithOptions - Add Fq and Fq_Codel Qdisc support Signed-off-by: Sebastiaan van Stijn <[email protected]>

…80abd Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah · 2019-06-24T13:06:03Z

rebased 👍

full diffs: - moby/libnetwork@fc5a7d9...62a13ae - vishvananda/netlink@b2de5d1...v1.0.0 - vishvananda/netns@604eaf1...13995c7 notable changes in libnetwork: - moby/libnetwork#2366 Bump vishvananda/netlink to 1.0.0 - moby/libnetwork#2339 controller: Check if IPTables is enabled for arrangeUserFilterRule - addresses moby/libnetwork#2158 dockerd when run with --iptables=false modifies iptables by adding DOCKER-USER - addresses moby#35777 With iptables=false dockerd still creates DOCKER-USER chain and rules - addresses docker/for-linux#136 dockerd --iptables=false adds DOCKER-USER chain and modify FORWARD chain anyway - moby/libnetwork#2394 Make DNS records and queries case-insensitive - addresses moby#28689 Embedded DNS is case-sensitive - addresses moby#21169 hostnames with new networking are case-sensitive Signed-off-by: Sebastiaan van Stijn <[email protected]>

full diffs: - moby/libnetwork@fc5a7d9...62a13ae - vishvananda/netlink@b2de5d1...v1.0.0 - vishvananda/netns@604eaf1...13995c7 notable changes in libnetwork: - moby/libnetwork#2366 Bump vishvananda/netlink to 1.0.0 - moby/libnetwork#2339 controller: Check if IPTables is enabled for arrangeUserFilterRule - addresses moby/libnetwork#2158 dockerd when run with --iptables=false modifies iptables by adding DOCKER-USER - addresses moby/moby#35777 With iptables=false dockerd still creates DOCKER-USER chain and rules - addresses docker/for-linux#136 dockerd --iptables=false adds DOCKER-USER chain and modify FORWARD chain anyway - moby/libnetwork#2394 Make DNS records and queries case-insensitive - addresses moby/moby#28689 Embedded DNS is case-sensitive - addresses moby/moby#21169 hostnames with new networking are case-sensitive Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: 344b093258fcb2195fa393081e5224a6c766c798 Component: engine

full diffs: - moby/libnetwork@fc5a7d9...62a13ae - vishvananda/netlink@b2de5d1...v1.0.0 - vishvananda/netns@604eaf1...13995c7 notable changes in libnetwork: - moby/libnetwork#2366 Bump vishvananda/netlink to 1.0.0 - moby/libnetwork#2339 controller: Check if IPTables is enabled for arrangeUserFilterRule - addresses moby/libnetwork#2158 dockerd when run with --iptables=false modifies iptables by adding DOCKER-USER - addresses moby#35777 With iptables=false dockerd still creates DOCKER-USER chain and rules - addresses docker/for-linux#136 dockerd --iptables=false adds DOCKER-USER chain and modify FORWARD chain anyway - moby/libnetwork#2394 Make DNS records and queries case-insensitive - addresses moby#28689 Embedded DNS is case-sensitive - addresses moby#21169 hostnames with new networking are case-sensitive Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 344b093) Signed-off-by: Sebastiaan van Stijn <[email protected]>

full diffs: - moby/libnetwork@fc5a7d9...62a13ae - vishvananda/netlink@b2de5d1...v1.0.0 - vishvananda/netns@604eaf1...13995c7 notable changes in libnetwork: - moby/libnetwork#2366 Bump vishvananda/netlink to 1.0.0 - moby/libnetwork#2339 controller: Check if IPTables is enabled for arrangeUserFilterRule - addresses moby/libnetwork#2158 dockerd when run with --iptables=false modifies iptables by adding DOCKER-USER - addresses moby/moby#35777 With iptables=false dockerd still creates DOCKER-USER chain and rules - addresses docker/for-linux#136 dockerd --iptables=false adds DOCKER-USER chain and modify FORWARD chain anyway - moby/libnetwork#2394 Make DNS records and queries case-insensitive - addresses moby/moby#28689 Embedded DNS is case-sensitive - addresses moby/moby#21169 hostnames with new networking are case-sensitive Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 344b093258fcb2195fa393081e5224a6c766c798) Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: f3e1aff81df959e9178433b77e7f3364c22aee59 Component: engine

full diffs: - moby/libnetwork@fc5a7d9...62a13ae - vishvananda/netlink@b2de5d1...v1.0.0 - vishvananda/netns@604eaf1...13995c7 notable changes in libnetwork: - moby/libnetwork#2366 Bump vishvananda/netlink to 1.0.0 - moby/libnetwork#2339 controller: Check if IPTables is enabled for arrangeUserFilterRule - addresses moby/libnetwork#2158 dockerd when run with --iptables=false modifies iptables by adding DOCKER-USER - addresses moby#35777 With iptables=false dockerd still creates DOCKER-USER chain and rules - addresses docker/for-linux#136 dockerd --iptables=false adds DOCKER-USER chain and modify FORWARD chain anyway - moby/libnetwork#2394 Make DNS records and queries case-insensitive - addresses moby#28689 Embedded DNS is case-sensitive - addresses moby#21169 hostnames with new networking are case-sensitive Signed-off-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: zach <[email protected]>

thaJeztah force-pushed the bump_netlink_1.0 branch 3 times, most recently from 611f0a9 to bde9b30 Compare April 10, 2019 16:32

This comment has been minimized.

Sign in to view

thaJeztah force-pushed the bump_netlink_1.0 branch 2 times, most recently from 9ed7c03 to 7b66143 Compare April 10, 2019 16:46

thaJeztah mentioned this pull request Apr 10, 2019

bump libnetwork. vishvananda/netlink 1.0, vishvananda/netns moby/moby#39054

Merged

thaJeztah mentioned this pull request May 23, 2019

Please update vishvananda/netns for ppc64 support moby/moby#39184

Closed

arkodg approved these changes Jun 4, 2019

View reviewed changes

euanh mentioned this pull request Jun 24, 2019

[wip] Bump vishvananda/netlink to 1.0.0 #2118

Closed

thaJeztah added 2 commits June 24, 2019 14:56

bump github.com/vishvananda/netns 13995c7128ccc8e51e9a6bd2b551020a271…

e6009a2

…80abd Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah force-pushed the bump_netlink_1.0 branch from 7b66143 to e6009a2 Compare June 24, 2019 12:57

euanh approved these changes Jun 24, 2019

View reviewed changes

euanh merged commit db33b49 into moby:master Jun 24, 2019

thaJeztah deleted the bump_netlink_1.0 branch June 24, 2019 13:31

thaJeztah mentioned this pull request Jun 25, 2019

ipvs.go:94:32: cannot use &tv (type *syscall.Timeval) as type *unix.Timeval in argument to sock.SetSendTimeout #2110

Closed

thaJeztah mentioned this pull request Aug 22, 2019

[19.03 backport] bump libnetwork to 92d1fbe1eb0883cf11d283cea8e658275146411d docker-archive/engine#330

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump vishvananda/netlink to 1.0.0#2366

Bump vishvananda/netlink to 1.0.0#2366
euanh merged 2 commits intomoby:masterfrom
thaJeztah:bump_netlink_1.0

thaJeztah commented Apr 10, 2019 •

edited

Loading

Uh oh!

This comment has been minimized.

thaJeztah commented Apr 10, 2019 •

edited

Loading

Uh oh!

thaJeztah commented Apr 10, 2019

Uh oh!

thaJeztah commented Apr 10, 2019

Uh oh!

thaJeztah commented Apr 10, 2019

Uh oh!

thaJeztah commented May 23, 2019

Uh oh!

arkodg left a comment

Uh oh!

thaJeztah commented Jun 4, 2019

Uh oh!

thaJeztah commented Jun 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

thaJeztah commented Apr 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

thaJeztah commented Apr 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Apr 10, 2019

Uh oh!

thaJeztah commented Apr 10, 2019

Uh oh!

thaJeztah commented Apr 10, 2019

Uh oh!

thaJeztah commented May 23, 2019

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Jun 4, 2019

Uh oh!

thaJeztah commented Jun 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thaJeztah commented Apr 10, 2019 •

edited

Loading

thaJeztah commented Apr 10, 2019 •

edited

Loading