Closed
Conversation
|
Please sign your commits following these rules: $ git clone -b "bump_netlink_1.0.0" [email protected]:dixudx/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
dixudx
force-pushed
the
bump_netlink_1.0.0
branch
2 times, most recently
from
5fc4443 to
4a97a53
Compare
Signed-off-by: Di Xu <[email protected]>
dixudx
force-pushed
the
bump_netlink_1.0.0
branch
from
4a97a53 to
c537300
Compare
dixudx
force-pushed
the
bump_netlink_1.0.0
branch
from
c537300 to
144b737
Compare
Signed-off-by: Di Xu <[email protected]>
dixudx
force-pushed
the
bump_netlink_1.0.0
branch
from
144b737 to
a9f364f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I use
CGO_ENABLED=1 GOARCH=amd64 GOOS=linuxto build the command on Mac,You need to set
CGO_ENABLED=0to make it work.This dependency
github.com/vishvananda/netlinknow eliminates cgo. We don't need to suffer this kind of error any more.Full diffs:
Current v1.0.0 of
github.com/vishvananda/netlinkneed to updategolang.org/x/sys/unix. And we could upgrade that later if needed.