Could someone help me understand what this failure might mean? Or help debug it? I'm not that familiar with libnetwork. Tentatively possible is a regression due to boltdb, purely based on supposition in that it has db in the name of the test.

--- FAIL: TestNetworkDBCRUDMediumCluster (16.92s)
	networkdb_test.go:112: Network existence verification failed
	networkdb_test.go:136: Entry existence verification test failed for node3(5e292e4e65e9)
	networkdb_test.go:136: Entry existence verification test failed for node3(5e292e4e65e9)
	networkdb_test.go:455: assertion failed: expression is false: strings.Contains(err.Error(), "deleted and pending garbage collection")

I suspect this is a flaky test. It doesn't look like NetworkDB uses bolt (bbolt). On a second run, it failed in a different way:

=== RUN   TestNetworkDBCRUDMediumCluster
--- FAIL: TestNetworkDBCRUDMediumCluster (2.06s)
	networkdb_test.go:57: Number of nodes for node3 into the cluster does not match 5 != 4

I'll give it a third CI attempt...

Ha, third time it passed. Pretty sure that's just a flaky test 😞

@thaJeztah FYI.

Yes. I dont know why and how networkdb fails for boltdb changes.
@fcrisciani might know more details on this.

Could you squash these three commits? Looks like they should go together;

• Bump libkv to 458977154600b9f23984d9f4b82e79570b5ae12b
• Remove github.com/boltdb/bolt from vendor.conf
• Vendor go.etcd.io/bbolt @ v1.3.1-etcd.8

Could you squash these three commits?

@thaJeztah Done

LGTM

thanks!

Who can merge this? I'd really like to get the fix into moby/moby due to the number of people hitting the issue