Skip to content

ipvs support get rs connection information#2258

Merged
ctelfer merged 1 commit intomoby:masterfrom
Lion-Wei:master
Aug 24, 2018
Merged

ipvs support get rs connection information#2258
ctelfer merged 1 commit intomoby:masterfrom
Lion-Wei:master

Conversation

@Lion-Wei
Copy link
Contributor

@Lion-Wei Lion-Wei commented Aug 22, 2018

Ipvs GetDestinations now can return ConnectionCount/InconnectionCount information

Which can be useful to determined whether a weight=0 destination can be remove or not.

Ref issue: #2237

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" [email protected]:Lion-Wei/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@Lion-Wei
Copy link
Contributor Author

@GordonTheTurtle Sure, signed, Please take another look.

Copy link
Contributor

@ctelfer ctelfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lion-Wei
Copy link
Contributor Author

@abhi @ctelfer Thanks for reviewing. And anything I can do to make this merged?

@ctelfer ctelfer merged commit 9decd25 into moby:master Aug 24, 2018
@ctelfer
Copy link
Contributor

ctelfer commented Aug 24, 2018

@Lion-Wei All good. Missed the 2nd LGTM. Thanks for the contribution!

@Lion-Wei
Copy link
Contributor Author

@ctelfer Thanks. : )

@m1093782566
Copy link
Contributor

NICE JOB! @Lion-Wei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants