Remove non-service cluster info on sbLeave#2176
Merged
fcrisciani merged 1 commit intomoby:masterfrom May 31, 2018
Merged
Conversation
The system should remove cluster service info including networkDB entries and DNS entries for container endpoints that are not part of a service as well as those that are part of a service. This used to be the normal sequence of operations but it moved to sandbox.DisableService() in an effort to more gracefully handle endpoint removal from a service (which proved insufficient). Unfortunately subsequent changes also removed the newly-mandetory call to sandbox.DisableService() preventing proper cleanup for non-service container endpoints. Signed-off-by: Chris Telfer <[email protected]>
Contributor
Author
|
This is the same fix as on the 17.06 branch pulled here: #2175. |
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
=========================================
Coverage ? 40.57%
=========================================
Files ? 139
Lines ? 22486
Branches ? 0
=========================================
Hits ? 9123
Misses ? 12032
Partials ? 1331
Continue to review full report at Codecov.
|
This was referenced Jul 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system should remove cluster service info including networkDB entries and DNS entries for container endpoints that are not part of a service as well as those that are part of a service. This used to be the normal sequence of operations but info removal moved to sandbox.DisableService() in an effort to more gracefully handle endpoint removal from a service (which proved insufficient). Unfortunately, subsequent fixes for graceful LB removal also removed the newly-mandatory call to sandbox.DisableService() preventing proper cleanup for non-service container endpoints. This patch restores the original logic of always removing cluster info.
Signed-off-by: Chris Telfer [email protected]