Skip to content

Comments

typo: fix misspells in code and comments#2164

Merged
fcrisciani merged 1 commit intomoby:masterfrom
idealhack:typo
May 29, 2018
Merged

typo: fix misspells in code and comments#2164
fcrisciani merged 1 commit intomoby:masterfrom
idealhack:typo

Conversation

@idealhack
Copy link
Contributor

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "typo" [email protected]:idealhack/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io
Copy link

codecov-io commented May 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8436c5c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2164   +/-   ##
=========================================
  Coverage          ?   40.58%           
=========================================
  Files             ?      139           
  Lines             ?    22496           
  Branches          ?        0           
=========================================
  Hits              ?     9131           
  Misses            ?    12026           
  Partials          ?     1339
Impacted Files Coverage Δ
drivers/bridge/setup_ipv4.go 67.56% <100%> (ø)
drivers/bridge/bridge.go 55.11% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8436c5c...ba402f6. Read the comment docs.

Copy link

@fcrisciani fcrisciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants