Skip to content

Comments

Improve interface order#2132

Merged
ctelfer merged 3 commits intomoby:masterfrom
cziebuhr:2093-iface_order2
May 30, 2018
Merged

Improve interface order#2132
ctelfer merged 3 commits intomoby:masterfrom
cziebuhr:2093-iface_order2

Conversation

@cziebuhr
Copy link
Contributor

@cziebuhr cziebuhr commented Mar 28, 2018

Solves #2093 b). PR is based on #2103.

cziebuhr added 2 commits March 21, 2018 10:31
@cziebuhr
Use ordered array instead of heap for sb.endpoints
c13db32 
Signed-off-by: Christoph Ziebuhr <[email protected]>
@cziebuhr
Make go-tools happy
056f8ec 
Signed-off-by: Christoph Ziebuhr <[email protected]>
@codecov-io
Copy link

codecov-io commented Mar 28, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@8436c5c). Click here to learn what that means.
The diff coverage is 88.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2132   +/-   ##
=========================================
  Coverage          ?   40.51%           
=========================================
  Files             ?      139           
  Lines             ?    22349           
  Branches          ?        0           
=========================================
  Hits              ?     9054           
  Misses            ?    11973           
  Partials          ?     1322
Impacted Files Coverage Δ
resolver.go 36.64% <0%> (ø)
sandbox_store.go 32.93% <0%> (ø)
endpoint.go 53.8% <100%> (ø)
controller.go 36.65% <100%> (ø)
sandbox.go 47.12% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8436c5c...19926ea. Read the comment docs.

@ctelfer
Copy link
Contributor

ctelfer commented Mar 29, 2018

The changes to the interface comparison LGTM. Might be worth amending the last commit with a cut-and-paste of the things we discussed in #2093 for reference. Or maybe put it as a comment to the Less() method.

@cziebuhr cziebuhr force-pushed the 2093-iface_order2 branch from 2621d6e to 29f6332 Compare April 3, 2018 13:16
@cziebuhr
Copy link
Contributor Author

cziebuhr commented Apr 3, 2018

PR has been updated

ctelfer
ctelfer approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@ctelfer ctelfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctelfer
Copy link
Contributor

ctelfer commented Apr 12, 2018

@fcrisciani @abhi @ddebroy Would any of you mind reviewing and do you think we should add a unit test case for it as well?

@ajones-rvbd ajones-rvbd mentioned this pull request Apr 28, 2018
Closed
@cziebuhr
Copy link
Contributor Author

cziebuhr commented May 23, 2018

bump

@ctelfer ctelfer requested a review from ddebroy May 23, 2018 13:55
@ddebroy
Copy link
Contributor

ddebroy commented May 23, 2018

The code LGTM. It would be great if unit-tests can be added that verifies the Less and enumeration order follows expected ordering.

@cziebuhr
Improve interface order
19926ea 
Signed-off-by: Christoph Ziebuhr <[email protected]>
@cziebuhr cziebuhr force-pushed the 2093-iface_order2 branch from 29f6332 to 19926ea Compare May 25, 2018 15:48
@cziebuhr
Copy link
Contributor Author

cziebuhr commented May 25, 2018

Unit tests have been adapted to the new ordering rules.

ddebroy
ddebroy approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for enhancing the test.

@ctelfer ctelfer merged commit 9ba7c0d into moby:master May 30, 2018
@ctelfer
Copy link
Contributor

ctelfer commented May 30, 2018

Thanks for the PR! Sorry it took so long. I suppose the next step is to now expose the priority fields in moby as configuration parameters.

@thaJeztah thaJeztah mentioned this pull request Jun 5, 2018
Merged
@cziebuhr
Copy link
Contributor Author

cziebuhr commented Jun 21, 2018

I don't think I can handle the next step myself. Is there any process other than keeping #2093 open to let someone continue who is more familiar with changing APIs?

@DrAuYueng DrAuYueng mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ctelfer ctelfer ctelfer approved these changes

@ddebroy ddebroy ddebroy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cziebuhr @codecov-io @ctelfer @ddebroy