[wip] Bump vishvananda/netlink to 1.0.0#2118
Closed
thaJeztah wants to merge 14 commits intomoby:masterfrom
Closed
Conversation
Member
Author
|
Looks like I need to update Looks like this needs golang/sys@88d2dcc, so let me bump it to current master; also need to bump moby/moby, to pull in moby/moby@86f080c |
thaJeztah
force-pushed
the
bump-netlink
branch
6 times, most recently
from
8f1e741 to
d637c89
Compare
thaJeztah
changed the title
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Changes included:
- Allow index specification at link creation time
- replace syscall with golang.org/x/sys/unix
- related: Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE
- related: Use IFLA_* constants from x/sys/unix
- Fix index out of range when no metadata for gretap
- added encapsulation attributes for Iptun and Sittun to support SIT tunnels
- Expose xfrm state's statistics
- Support invert in ip rules
- Support LWTUNNEL_ENCAP_SEG6
- Support setting and retrieving route MTU/AdvMSS
- Fix CalcRtable array parameter bug
- added support for Foo-over-UDP netlink calls
- Support num{tx,rx}queues and udp6zerocsum{tx,rx}
- tuntap: Add multiqueue support
- Retrieve VLAN ID when listing neighbour
- Fix LinkAdd for sit tunnel on 3.10 kernel
- Add support for managing source MACVLANs
- Two functions: one for adding bond slave, one for getting veth peer index
- Eliminate cgo from netlink
- Don't overwrite the XDP file descriptor with flags
- Fix reference to BPF instructions (on Kernel 4.13)
- Add Matchall filter
- Send IFA_CACHEINFO when setting up addresses
- Support IPv6 GRE Tun and Tap
- Add List option to RouteSubscribeWithOptions, AddrSubscribeWithOptions, and LinkSubscribeWithOptions
- Add Fq and Fq_Codel Qdisc support
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Also adds github.com/coreos/pkg as a dependency Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
…faf27fd357b6 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Also adds github.com/cyphar/filepath-securejoin Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Mar 20, 2018
|
|
||
| if err != nil { | ||
| if err == plugins.ErrNotFound { | ||
| if errors.Cause(err) == plugins.ErrNotFound { |
Member
Author
There was a problem hiding this comment.
This fixes:
--- FAIL: TestUnknownDriver (15.00s)
libnetwork_test.go:213: Did not fail with expected error. Actual error: could not find plugin unknowndriver in v1 plugin registry: plugin not found
--- FAIL: TestNilRemoteDriver (15.00s)
libnetwork_test.go:225: Did not fail with expected error. Actual error: could not find plugin framerelay in v1 plugin registry: plugin not found
Member
Author
There was a problem hiding this comment.
Wonder if this is an actual issue currently; this was revealed due to docker/docker being bumped here, but likely is an issue in the current version in that repository
thaJeztah
commented
Mar 20, 2018
|
|
||
| if err != nil { | ||
| if err == plugins.ErrNotFound { | ||
| if errors.Cause(err) == plugins.ErrNotFound { |
Member
Author
There was a problem hiding this comment.
Similar to the above, but not sure if there's a test case covering this;
--- FAIL: TestUnknownDriver (15.00s)
libnetwork_test.go:213: Did not fail with expected error. Actual error: could not find plugin unknowndriver in v1 plugin registry: plugin not found
--- FAIL: TestNilRemoteDriver (15.00s)
libnetwork_test.go:225: Did not fail with expected error. Actual error: could not find plugin framerelay in v1 plugin registry: plugin not found
Member
Author
|
Noticed this warning; will have to look into this one; This looks like an actual failure: |
|
cc @abhi looks like one of the IPAM tests failed here |
Contributor
|
No <3 for this? |
|
did this die in usersub? |
This was referenced Apr 10, 2019
Contributor
|
Superseded by #2366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full diff: vishvananda/netlink@b2de5d1...v1.0.0
Changes included:
ping @aboch @fcrisciani PTAL
Looks like with this changes, only the
system/meminfocode is needing CGO https://github.com/docker/libnetwork/blob/873af3416744d02ea044cf02a46d6dc3857b9062/vendor/github.com/docker/docker/pkg/system/meminfo_solaris.go#L1, which could probably be updated