Fix golang.org/x/sync canonical import path#2111
Merged
fcrisciani merged 1 commit intomoby:masterfrom Mar 14, 2018
Merged
Conversation
Merged
Member
Author
|
ping @fcrisciani @vdemeester @ddebroy PTAL |
The golang.org/x/sync package was vendored using the
github.com/golang/sync URL, but this is not the canonical
URL.
Because of this, vendoring failed in Moby, as it detects
these to be a duplicate import:
vndr github.com/golang/sync
2018/03/14 11:54:37 Collecting initial packages
2018/03/14 11:55:00 Download dependencies
2018/03/14 11:55:00 Failed to parse config: invalid config format: // FIXME this should be golang.org/x/sync, which is already vendored above
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix-golang-sync-canonical-import
branch
from
974908e to
756b2d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
=========================================
Coverage ? 40.42%
=========================================
Files ? 139
Lines ? 22376
Branches ? 0
=========================================
Hits ? 9046
Misses ? 12002
Partials ? 1328Continue to review full report at Codecov.
|
|
tnx @thaJeztah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golang.org/x/sync package was vendored using the github.com/golang/sync URL in #2104, but this is not the canonical URL.
Because of this, vendoring failed in Moby, as it detects these to be a duplicate import: