Conversation
|
Tests are expected to fail |
fcrisciani
force-pushed
the
test-ipam
branch
2 times, most recently
from
8686170 to
5ce03c1
Compare
|
@mghazizadeh @antonybichon17 @andrewhsu This is one of the test scenarios that reproduces the issue. The fix and additional tests are available at #2105. |
|
To not lose the failure on master: https://circleci.com/gh/docker/libnetwork/5992 |
fcrisciani
force-pushed
the
test-ipam
branch
3 times, most recently
from
51039f2 to
36d4b8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
========================================
Coverage ? 40.4%
========================================
Files ? 139
Lines ? 22376
Branches ? 0
========================================
Hits ? 9040
Misses ? 12008
Partials ? 1328
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
For the sake of unit testing completeness and coverage, will it make sense to add some tests to TestSequenceGetAvailableBit with sequence blocks with holes in the middle like say 0xffcfffff, from set to somewhere in the middle beyond which there are no bits like 8 and expect invalidPos, invalidPos to cover the new full-detection in getAvailableBit in PR 2105?
|
@ddebroy I have added that scenario implicitly in that test where it moves on to the next block because of the invalidPos. Are you suggesting we explicitly add it as well ? |
|
Right ... that was my suggestion. Not a high priority and can be added later for completeness since it's implicitly covered right now as you mentioned. |
Signed-off-by: Flavio Crisciani <[email protected]>
Added tests for swarm mode and also some new parallel tests Signed-off-by: Flavio Crisciani <[email protected]>
| golang.org/x/crypto 558b6879de74bc843225cde5686419267ff707ca | ||
| golang.org/x/net 7dcfb8076726a3fdd9353b6b8a1f1b6be6811bd6 | ||
| golang.org/x/sys 07c182904dbd53199946ba614a412c61d3c548f5 | ||
| github.com/golang/sync fd80eb99c8f653c847d294a001bdf2a3a6f768f5 |
There was a problem hiding this comment.
This uses the wrong (non-canonical) import path; see #2111 (and https://github.com/moby/moby/pull/36589/files#r174434213)
5 participants
Added tests for swarm mode and also some new parallel tests with various subnets
Signed-off-by: Flavio Crisciani [email protected]