Moving IPAM initalization out of drvRegistry into libnetwork core#1310
Merged
aboch merged 1 commit intomoby:masterfrom Jul 6, 2016
Merged
Moving IPAM initalization out of drvRegistry into libnetwork core#1310aboch merged 1 commit intomoby:masterfrom
aboch merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Madhu Venugopal <[email protected]>
| return i.defaultLocalAddressSpace, i.defaultGlobalAddressSpace, nil | ||
| } | ||
|
|
||
| func (r *DrvRegistry) initIPAMs(lDs, gDs interface{}) error { |
Contributor
There was a problem hiding this comment.
Can we instead make this method exported so that in controller.go we just call it as
drvRegistry.InitIPAMDrivers(nil, c.getStore(datastore.GlobalScope));
we'd achieve the same thing I think.
Contributor
Author
There was a problem hiding this comment.
The point of this change is to remove the IPAM driver dependancy from drvRegistry.
Contributor
There was a problem hiding this comment.
Ok, so the point is to allow the creator of DrvRegistry to control which ipam drivers needs to be registered.
Contributor
|
LGTM |
This was referenced Jul 6, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Madhu Venugopal [email protected]