Rename package specs & retract v1.3.0 tag#1
Merged
Conversation
Contributor
Author
|
For reference, retract directives only need to be present in the highest numbered version of the module. Tags v1.0.1, v1.1.1 and v1.2.1 only need to be pushed with the |
Member
|
v1.3.0 is the only tag that has code in the repo; older tags only have the specification |
Contributor
Author
|
Well that makes things easier! I'll remove the unnecessary retractions, one sec |
The package at package path github.com/moby/docker-image-spec/specs-go was assigned the package name 'v1'. It is supposed to have the package name 'specs' to mirror the name of the github.com/opencontainers/image-spec/specs-go package, but this mistake was not caught until after stable module versions were tagged. Fix the package name and retract the v1.3.0 tag. Signed-off-by: Cory Snider <[email protected]>
corhere
force-pushed
the
fix-package-name
branch
from
c64213d to
d07bc4c
Compare
corhere
changed the title
Member
|
Not near a computer; are you able to create a tag, @corhere ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package at package path github.com/moby/docker-image-spec/specs-go was assigned the package name
v1. It is supposed to have the package namespecsto mirror the name of thegithub.com/opencontainers/image-spec/specs-go package, but this mistake was not caught until after stable module versions were tagged. Fix the package name and retract all the existing module versions.